Distribute rustc_codegen_cranelift for Windows #128939

bjorn3 · 2024-08-10T19:24:47Z

With support for raw-dylib recently added to cg_clif, and inline assembly support working on Windows for quite a while now, all blockers for distributing cg_clif on Windows that I mentioned in #81746 (comment) are fixed now.

rustbot · 2024-08-10T19:24:54Z

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

bjorn3 · 2024-08-10T19:24:58Z

@bors try

…<try> [WIP] Distribute rustc_codegen_cranelift for Windows try-job: dist-x86_64-msvc try-job: dist-i686-msvc try-job: dist-i686-mingw try-job: dist-x86_64-mingw

bors · 2024-08-10T19:26:08Z

⌛ Trying commit 8a8896d with merge d3b4306...

bors · 2024-08-10T21:02:40Z

☀️ Try build successful - checks-actions
Build commit: d3b4306 (d3b4306976392198298d7ef958db7a4c9b0610c5)

bjorn3 · 2024-08-10T21:19:46Z

If someone on Windows could check if the above try build produced a toolchain with working cg_clif, that would be appreciated.

lqd · 2024-08-10T22:03:21Z

A reboot later.

I was expecting to install it like the following:

> rustup-toolchain-install-master d3b4306976392198298d7ef958db7a4c9b0610c5 --component rustc-codegen-cranelift-preview
error: missing component `rustc-codegen-cranelift-preview` on toolchain `d3b4306976392198298d7ef958db7a4c9b0610c5` on channel `nightly` for target `x86_64-pc-windows-msvc`

With luck I tried with the component named as rustc-codegen-cranelift though, and the toolchain installed successfully!

This is how a helloworld looks:

$ cargo clean -q && CARGO_PROFILE_DEV_CODEGEN_BACKEND=cranelift cargo +d3b4306976392198298d7ef958db7a4c9b0610c5 run -Zcodegen-backend -q
Hello, world!

I'm not sure if there's a way to ensure cg_clif was used, but I'd assume so.

bjorn3 · 2024-08-11T08:26:49Z

Thanks for checking!

albertlarsan68 · 2024-09-04T16:10:07Z

(sorry for the slow review, I needed time off)

Thanks for the PR!
@bors r+

bors · 2024-09-04T16:10:10Z

📌 Commit 2dbc976 has been approved by albertlarsan68

It is now in the queue for this repository.

…r=albertlarsan68 Distribute rustc_codegen_cranelift for Windows With support for raw-dylib recently added to cg_clif, and inline assembly support working on Windows for quite a while now, all blockers for distributing cg_clif on Windows that I mentioned in rust-lang#81746 (comment) are fixed now.

…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#119229 (Update mingw-w64 + GNU toolchain) - rust-lang#128871 (bypass linker configuration and cross target check for specific commands) - rust-lang#128939 (Distribute rustc_codegen_cranelift for Windows) - rust-lang#129529 (Add test to build crates used by r-a on stable) - rust-lang#129624 (Adjust `memchr` pinning and run `cargo update`) - rust-lang#129835 (enable const-float-classify test, and test_next_up/down on 32bit x86) - rust-lang#130009 (rustdoc-search: allow trailing `Foo ->` arg search) r? `@ghost` `@rustbot` modify labels: rollup

GuillaumeGomez · 2024-09-06T14:19:46Z

I wonder if this the one which failed in #130027...

lqd · 2024-09-06T15:59:09Z

Doesn't look like it, windows CI's just on fire at the moment, but you can rollup=never if that'd make you feel better :)

GuillaumeGomez · 2024-09-06T18:42:36Z

I was just blindly guessing because no PR seemed to fit the failure and someone commented on the rollup that it's a known flaky bug. So all good here.

…r=albertlarsan68 Distribute rustc_codegen_cranelift for Windows With support for raw-dylib recently added to cg_clif, and inline assembly support working on Windows for quite a while now, all blockers for distributing cg_clif on Windows that I mentioned in rust-lang#81746 (comment) are fixed now.

…kingjubilee Rollup of 16 pull requests Successful merges: - rust-lang#119229 (Update mingw-w64 + GNU toolchain) - rust-lang#128345 (added support for GNU/Hurd on x86_64) - rust-lang#128667 (rustdoc: normalise type/field names) - rust-lang#128939 (Distribute rustc_codegen_cranelift for Windows) - rust-lang#129529 (Add test to build crates used by r-a on stable) - rust-lang#129624 (Adjust `memchr` pinning and run `cargo update`) - rust-lang#129876 (Use sysroot crates maximally in `rustc_codegen_gcc`.) - rust-lang#130034 ( Fix enabling wasm-component-ld to match other tools ) - rust-lang#130048 (run-make-support: Add llvm-pdbutil) - rust-lang#130068 (Test codegen when setting deployment target) - rust-lang#130070 (Rename variant `AddrOfRegion` of `RegionVariableOrigin` to `BorrowRegion`) - rust-lang#130087 (remove 'const' from 'Option::iter') - rust-lang#130090 (make Result::copied unstably const) - rust-lang#130092 (Fixes typo in wasm32-wasip2 doc comment) - rust-lang#130107 (const: make ptr.is_null() stop execution on ambiguity) - rust-lang#130115 (Remove needless returns detected by clippy in libraries) r? `@ghost` `@rustbot` modify labels: rollup

workingjubilee · 2024-09-09T07:19:03Z

It's not about you, it's about Windows.

@bors rollup=iffy

…albertlarsan68 Distribute rustc_codegen_cranelift for Windows With support for raw-dylib recently added to cg_clif, and inline assembly support working on Windows for quite a while now, all blockers for distributing cg_clif on Windows that I mentioned in rust-lang#81746 (comment) are fixed now.

bors · 2024-09-09T14:14:14Z

⌛ Testing commit 2dbc976 with merge 3d9d39f...

rust-log-analyzer · 2024-09-09T15:15:10Z

The job x86_64-msvc-ext2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] miri test:false 4.409
error: failed to remove file `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-tools\x86_64-pc-windows-msvc\release\miri.exe`

Caused by:
  Access is denied. (os error 5)
Command has failed. Rerun with -v to see more details.
  local time: Mon, Sep  9, 2024  3:14:55 PM
  network time: Mon, 09 Sep 2024 15:14:55 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

bors · 2024-09-09T15:16:24Z

💔 Test failed - checks-actions

ChrisDenton · 2024-09-09T15:36:08Z

@bors retry

bors · 2024-09-09T16:09:09Z

⌛ Testing commit 2dbc976 with merge d7522d8...

bors · 2024-09-09T18:51:59Z

☀️ Test successful - checks-actions
Approved by: albertlarsan68
Pushing d7522d8 to master...

rust-timer · 2024-09-09T20:12:57Z

Finished benchmarking commit (d7522d8): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.5%	[-0.5%, -0.5%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -2.1%, secondary 2.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.6%, 3.0%]	2
Improvements ✅ (primary)	-2.1%	[-2.1%, -2.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.1%	[-2.1%, -2.1%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 757.15s -> 756.6s (-0.07%)
Artifact size: 341.19 MiB -> 341.19 MiB (-0.00%)

…albertlarsan68 Distribute rustc_codegen_cranelift for Windows With support for raw-dylib recently added to cg_clif, and inline assembly support working on Windows for quite a while now, all blockers for distributing cg_clif on Windows that I mentioned in rust-lang#81746 (comment) are fixed now.

rustbot assigned albertlarsan68 Aug 10, 2024

This comment has been minimized.

# to view

Distribute rustc_codegen_cranelift for Windows

2dbc976

bjorn3 force-pushed the windows_cg_clif_component branch from 8a8896d to 2dbc976 Compare August 10, 2024 21:17

bjorn3 changed the title ~~[WIP] Distribute rustc_codegen_cranelift for Windows~~ Distribute rustc_codegen_cranelift for Windows Aug 11, 2024

bjorn3 marked this pull request as ready for review August 11, 2024 08:27

bjorn3 added A-cranelift Things relevant to the [future] cranelift backend and removed A-testsuite Area: The testsuite used to check the correctness of rustc labels Aug 11, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2024

GuillaumeGomez mentioned this pull request Sep 6, 2024

Rollup of 7 pull requests #130027

Closed

workingjubilee mentioned this pull request Sep 9, 2024

Rollup of 19 pull requests #130127

Closed

workingjubilee mentioned this pull request Sep 9, 2024

Rollup of 16 pull requests #130129

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 9, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 9, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 9, 2024

bors merged commit d7522d8 into rust-lang:master Sep 9, 2024
7 checks passed

rustbot added this to the 1.83.0 milestone Sep 9, 2024

bjorn3 deleted the windows_cg_clif_component branch September 10, 2024 15:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Distribute rustc_codegen_cranelift for Windows #128939

Distribute rustc_codegen_cranelift for Windows #128939

bjorn3 commented Aug 10, 2024 •

edited

Loading

rustbot commented Aug 10, 2024

bjorn3 commented Aug 10, 2024

bors commented Aug 10, 2024

This comment has been minimized.

bors commented Aug 10, 2024

bjorn3 commented Aug 10, 2024

lqd commented Aug 10, 2024

bjorn3 commented Aug 11, 2024

albertlarsan68 commented Sep 4, 2024

bors commented Sep 4, 2024

GuillaumeGomez commented Sep 6, 2024

lqd commented Sep 6, 2024

GuillaumeGomez commented Sep 6, 2024

workingjubilee commented Sep 9, 2024

bors commented Sep 9, 2024

rust-log-analyzer commented Sep 9, 2024

bors commented Sep 9, 2024

ChrisDenton commented Sep 9, 2024

bors commented Sep 9, 2024

bors commented Sep 9, 2024

rust-timer commented Sep 9, 2024

Distribute rustc_codegen_cranelift for Windows #128939

Distribute rustc_codegen_cranelift for Windows #128939

Conversation

bjorn3 commented Aug 10, 2024 • edited Loading

rustbot commented Aug 10, 2024

bjorn3 commented Aug 10, 2024

bors commented Aug 10, 2024

This comment has been minimized.

bors commented Aug 10, 2024

bjorn3 commented Aug 10, 2024

lqd commented Aug 10, 2024

bjorn3 commented Aug 11, 2024

albertlarsan68 commented Sep 4, 2024

bors commented Sep 4, 2024

GuillaumeGomez commented Sep 6, 2024

lqd commented Sep 6, 2024

GuillaumeGomez commented Sep 6, 2024

workingjubilee commented Sep 9, 2024

bors commented Sep 9, 2024

rust-log-analyzer commented Sep 9, 2024

bors commented Sep 9, 2024

ChrisDenton commented Sep 9, 2024

bors commented Sep 9, 2024

bors commented Sep 9, 2024

rust-timer commented Sep 9, 2024

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

bjorn3 commented Aug 10, 2024 •

edited

Loading