[DO NOT MERGE] testing dump-ice-to-disk
#128958
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-run-make
|
@bors try |
jieyouxu
added
S-experimental
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 11, 2024
[DO NOT MERGE] testing `dump-ice-to-disk` Now how flakey is this r? `@ghost` try-job: i686-mingw
|
☀️ Try build successful - checks-actions |
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 11, 2024
[DO NOT MERGE] testing `dump-ice-to-disk` Now how flakey is this r? `@ghost` try-job: i686-mingw
|
☀️ Try build successful - checks-actions |
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 11, 2024
[DO NOT MERGE] testing `dump-ice-to-disk` Now how flakey is this r? `@ghost` try-job: i686-mingw
|
☀️ Try build successful - checks-actions |
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 11, 2024
[DO NOT MERGE] testing `dump-ice-to-disk` Now how flakey is this r? `@ghost` try-job: i686-mingw
|
☀️ Try build successful - checks-actions |
|
Stop succeeding, start failing! |
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 11, 2024
[DO NOT MERGE] testing `dump-ice-to-disk` Now how flakey is this r? `@ghost` try-job: i686-mingw
|
☀️ Try build successful - checks-actions |
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 12, 2024
[DO NOT MERGE] testing `dump-ice-to-disk` Now how flakey is this r? `@ghost` try-job: i686-mingw
|
☀️ Try build successful - checks-actions |
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 12, 2024
[DO NOT MERGE] testing `dump-ice-to-disk` Now how flakey is this r? `@ghost` try-job: i686-mingw
|
☀️ Try build successful - checks-actions |
|
@bors try |
|
One last try. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 12, 2024
[DO NOT MERGE] testing `dump-ice-to-disk` Now how flakey is this r? `@ghost` try-job: i686-mingw
|
☀️ Try build successful - checks-actions |
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 12, 2024
[DO NOT MERGE] testing `dump-ice-to-disk` Now how flakey is this r? `@ghost` try-job: i686-mingw
|
Maybe your changes fixed it somehow? |
If this try job still passes, I'm going to try remove the |
|
☀️ Try build successful - checks-actions |
rust-cloud-vms bot
pushed a commit
to jieyouxu/rust
that referenced
this pull request
Aug 15, 2024
This test was previously flakey on `i686-mingw`, but since some modifications I could no longer make it fail on `i686-mingw`. See <rust-lang#128958> for multiple try job runs.
This was referenced Aug 15, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 15, 2024
Re-enable `dump-ice-to-disk` for Windows This test was previously flakey on `i686-mingw`, but since some modifications (quarantining each ICE test in separate tmp dirs, adding/removing `RUSTC_ICE` env vars as suitable to prevent any kind of environmental influence), I could no longer make it fail on `i686-mingw`. I tried running this test (without the `ignore-windows` of course) a bunch of times via `i686-mingw` try jobs and it refused to fail (see rust-lang#128958). In any case, if this turns out to be still flakey on `i686-mingw`, we can revert the removal of `ignore-windows` but this time we'll have way more context for why the test failed. Running the `i686-mingw` alongside some Windows jobs for basic santiy check. But the try jobs succeeding is insufficient to guarantee reproducibility. cc rust-lang#129115 for backlink. try-job: x86_64-msvc try-job: x86_64-mingw try-job: i686-msvc try-job: i686-mingw
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Aug 17, 2024
…bank Re-enable `dump-ice-to-disk` for Windows This test was previously flakey on `i686-mingw` (reason unknown), but since some modifications (quarantining each ICE test in separate tmp dirs, adding/removing `RUSTC_ICE` env vars as suitable to prevent any kind of environmental influence), I could no longer make it fail on `i686-mingw`. I tried running this test (without the `ignore-windows` of course) a bunch of times via `i686-mingw` try jobs and it refused to fail (see rust-lang#128958). I was also never able to reproduce the failure locally. In any case, if this turns out to be still flakey on `i686-mingw`, we can revert the removal of `ignore-windows` but this time we'll have way more context for why the test failed. Running the `i686-mingw` alongside some Windows jobs for basic santiy check. But the try jobs succeeding is insufficient to guarantee reproducibility. cc rust-lang#129115 for backlink. try-job: x86_64-msvc try-job: x86_64-mingw try-job: i686-msvc try-job: i686-mingw
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Aug 17, 2024
…bank Re-enable `dump-ice-to-disk` for Windows This test was previously flakey on `i686-mingw` (reason unknown), but since some modifications (quarantining each ICE test in separate tmp dirs, adding/removing `RUSTC_ICE` env vars as suitable to prevent any kind of environmental influence), I could no longer make it fail on `i686-mingw`. I tried running this test (without the `ignore-windows` of course) a bunch of times via `i686-mingw` try jobs and it refused to fail (see rust-lang#128958). I was also never able to reproduce the failure locally. In any case, if this turns out to be still flakey on `i686-mingw`, we can revert the removal of `ignore-windows` but this time we'll have way more context for why the test failed. Running the `i686-mingw` alongside some Windows jobs for basic santiy check. But the try jobs succeeding is insufficient to guarantee reproducibility. cc rust-lang#129115 for backlink. try-job: x86_64-msvc try-job: x86_64-mingw try-job: i686-msvc try-job: i686-mingw
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Aug 17, 2024
…bank Re-enable `dump-ice-to-disk` for Windows This test was previously flakey on `i686-mingw` (reason unknown), but since some modifications (quarantining each ICE test in separate tmp dirs, adding/removing `RUSTC_ICE` env vars as suitable to prevent any kind of environmental influence), I could no longer make it fail on `i686-mingw`. I tried running this test (without the `ignore-windows` of course) a bunch of times via `i686-mingw` try jobs and it refused to fail (see rust-lang#128958). I was also never able to reproduce the failure locally. In any case, if this turns out to be still flakey on `i686-mingw`, we can revert the removal of `ignore-windows` but this time we'll have way more context for why the test failed. Running the `i686-mingw` alongside some Windows jobs for basic santiy check. But the try jobs succeeding is insufficient to guarantee reproducibility. cc rust-lang#129115 for backlink. try-job: x86_64-msvc try-job: x86_64-mingw try-job: i686-msvc try-job: i686-mingw
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 18, 2024
Re-enable `dump-ice-to-disk` for Windows This test was previously flakey on `i686-mingw` (reason unknown), but since some modifications (quarantining each ICE test in separate tmp dirs, adding/removing `RUSTC_ICE` env vars as suitable to prevent any kind of environmental influence), I could no longer make it fail on `i686-mingw`. I tried running this test (without the `ignore-windows` of course) a bunch of times via `i686-mingw` try jobs and it refused to fail (see rust-lang#128958). I was also never able to reproduce the failure locally. In any case, if this turns out to be still flakey on `i686-mingw`, we can revert the removal of `ignore-windows` but this time we'll have way more context for why the test failed. Running the `i686-mingw` alongside some Windows jobs for basic santiy check. But the try jobs succeeding is insufficient to guarantee reproducibility. cc rust-lang#129115 for backlink. try-job: x86_64-msvc try-job: x86_64-mingw try-job: i686-msvc try-job: i686-mingw
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now how flakey is this
r? @ghost
try-job: i686-mingw