Re-enable more debuginfo tests on Windows #128982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 11, 2024
…<try> Enable more debuginfo tests on Windows r? `@ghost` try-job: x86_64-msvc
This comment has been minimized.
This comment has been minimized.
saethlin
force-pushed
the
windows-debuginfo-tests
branch
from
563d795 to
39e5327
Compare
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 11, 2024
…<try> Enable more debuginfo tests on Windows r? `@ghost` try-job: i686-msvc try-job: i686-mingw try-job: x86_64-mingw
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-author
saethlin
force-pushed
the
windows-debuginfo-tests
branch
from
39e5327 to
c0ff855
Compare
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 11, 2024
…<try> Enable more debuginfo tests on Windows r? `@ghost` try-job: i686-msvc try-job: i686-mingw try-job: x86_64-mingw
|
☀️ Try build successful - checks-actions |
saethlin
changed the title
saethlin
force-pushed
the
windows-debuginfo-tests
branch
2 times, most recently
from
bc68b9c to
8df3381
Compare
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 16, 2024
…<try> Re-enable more debuginfo tests on Windows The changes in this PR are not tested by PR CI, but I've tested it using try-jobs below. try-job: i686-msvc try-job: i686-mingw try-job: x86_64-mingw try-job: x86_64-msvc
|
☀️ Try build successful - checks-actions |
|
@bors r+ |
bors
added
S-waiting-on-bors
saethlin
force-pushed
the
windows-debuginfo-tests
branch
from
8df3381 to
70320c1
Compare
|
@bors r=compiler-errors |
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Aug 17, 2024
…r=compiler-errors Re-enable more debuginfo tests on Windows These tests used to be disabled on all Windows hosts. Now they're fully enabled or just disabled on windows-gnu with an issue citation that clearly explains why. The changes in this PR are not tested by PR CI, but I've tested it using try-jobs below. try-job: i686-msvc try-job: i686-mingw try-job: x86_64-mingw try-job: x86_64-msvc
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Aug 17, 2024
…r=compiler-errors Re-enable more debuginfo tests on Windows These tests used to be disabled on all Windows hosts. Now they're fully enabled or just disabled on windows-gnu with an issue citation that clearly explains why. The changes in this PR are not tested by PR CI, but I've tested it using try-jobs below. try-job: i686-msvc try-job: i686-mingw try-job: x86_64-mingw try-job: x86_64-msvc
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 17, 2024
Rollup of 9 pull requests Successful merges: - rust-lang#128786 (Detect multiple crate versions on method not found) - rust-lang#128982 (Re-enable more debuginfo tests on Windows) - rust-lang#128989 (Emit an error for invalid use of the linkage attribute) - rust-lang#129115 (Re-enable `dump-ice-to-disk` for Windows) - rust-lang#129164 (Use `ar_archive_writer` for writing COFF import libs on all backends) - rust-lang#129167 (mir/pretty: use `Option` instead of `Either<Once, Empty>`) - rust-lang#129168 (Return correct HirId when finding body owner in diagnostics) - rust-lang#129173 (Fix `is_val_statically_known` for floats) - rust-lang#129185 (Port `run-make/libtest-json/validate_json.py` to Rust) r? `@ghost` `@rustbot` modify labels: rollup
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Aug 17, 2024
…r=compiler-errors Re-enable more debuginfo tests on Windows These tests used to be disabled on all Windows hosts. Now they're fully enabled or just disabled on windows-gnu with an issue citation that clearly explains why. The changes in this PR are not tested by PR CI, but I've tested it using try-jobs below. try-job: i686-msvc try-job: i686-mingw try-job: x86_64-mingw try-job: x86_64-msvc
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 17, 2024
Rollup of 6 pull requests Successful merges: - rust-lang#128771 (Stabilize `unsafe_attributes`) - rust-lang#128982 (Re-enable more debuginfo tests on Windows) - rust-lang#129115 (Re-enable `dump-ice-to-disk` for Windows) - rust-lang#129173 (Fix `is_val_statically_known` for floats) - rust-lang#129185 (Port `run-make/libtest-json/validate_json.py` to Rust) - rust-lang#129190 (Added f16 and f128 to tests/ui/consts/const-float-bits-conv.rs) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 18, 2024
…compiler-errors Re-enable more debuginfo tests on Windows These tests used to be disabled on all Windows hosts. Now they're fully enabled or just disabled on windows-gnu with an issue citation that clearly explains why. The changes in this PR are not tested by PR CI, but I've tested it using try-jobs below. try-job: i686-msvc try-job: i686-mingw try-job: x86_64-mingw try-job: x86_64-msvc
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (79f5c16): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (secondary 4.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 2.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 749.938s -> 750.626s (0.09%) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests used to be disabled on all Windows hosts. Now they're fully enabled or just disabled on windows-gnu with an issue citation that clearly explains why.
The changes in this PR are not tested by PR CI, but I've tested it using try-jobs below.
try-job: i686-msvc
try-job: i686-mingw
try-job: x86_64-mingw
try-job: x86_64-msvc