Skip to content

Disable dump-ice-to-disk for i686-mingw (again) #129227

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

jieyouxu
Copy link
Member

To avoid blocking full CI or i686-mingw try jobs (failed in #127679 (comment)).

At least we now have some context for why the assertion failed.

Anyone with r+ can approve this.

@rustbot
Copy link
Collaborator

rustbot commented Aug 18, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2024
@jieyouxu
Copy link
Member Author

@bors p=10 rollup=always (disables the flaky dump-ice-to-disk run-make test on windows for now)

@Kobzol
Copy link
Contributor

Kobzol commented Aug 18, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 18, 2024

📌 Commit ce7a70a has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2024
@bors
Copy link
Collaborator

bors commented Aug 18, 2024

⌛ Testing commit ce7a70a with merge 334e509...

@bors
Copy link
Collaborator

bors commented Aug 18, 2024

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 334e509 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 18, 2024
@bors bors merged commit 334e509 into rust-lang:master Aug 18, 2024
7 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 18, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (334e509): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.2% [-0.2%, -0.2%] 2
Improvements ✅
(secondary)
-0.2% [-0.2%, -0.2%] 2
All ❌✅ (primary) -0.2% [-0.2%, -0.2%] 2

Max RSS (memory usage)

Results (secondary -1.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.3% [1.3%, 1.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.9% [-4.8%, -0.9%] 2
All ❌✅ (primary) - - 0

Cycles

Results (primary -3.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.0% [-3.0%, -3.0%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -3.0% [-3.0%, -3.0%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 751.941s -> 749.337s (-0.35%)
Artifact size: 339.14 MiB -> 339.12 MiB (-0.00%)

@jieyouxu jieyouxu deleted the no-dumping branch August 20, 2024 06:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-run-make Area: port run-make Makefiles to rmake.rs merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants