Skip to content

Rollup of 7 pull requests #129407

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

Rollup of 7 pull requests #129407

wants to merge 19 commits into from

Conversation

tgross35
Copy link
Contributor

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Mrmaxmeier and others added 19 commits July 29, 2024 12:35
@Mrmaxmeier
Add -Z embed-source=yes to embed source code in DWARF debug info
0b87af9
@Mrmaxmeier
Add run-make test for -Zembed-source=yes
608901b
@tgross35
Enable f16 on x86 and x86-64
e518451 
Since the `compiler_builtins` update [1], ABI bugs on x86 should be
resolved. Enable tests for f16 on these platforms now.

[1]: rust-lang#125016
@tgross35
Change f16 doctests in core to run on x86-64
0a5d5ff 
Since `f16` now works on x86 and x86-64, change doctests to use this
instead of aarch64. This is to make sure any changes get run in PR CI.
@Mrmaxmeier
-Zembed-source: Don't try to warn about incompatible codegen backends
6899f5a
@ColinFinck
Ship MinGW-w64 runtime DLLs along with rust-lld.exe for `-pc-window…
71d98a8 
…s-gnu` targets

`rust-lld.exe` built for `x86_64-pc-windows-gnu` depends on `libgcc_s_seh-1.dll` and `libwinpthread-1.dll` from MinGW-w64.
Until now, they were not shipped alongside `rust-lld.exe`, and you could not run `rust-lld.exe` on most systems.

This problem didn't surface until now because:
* Most targets don't use `rust-lld` by default.
* Some people had these DLLs in their `PATH` from some other MinGW binary.
* `rustup` used to add `bin` to the `PATH`, which contains these DLLs for `rustc.exe`. But it no longer does that: rust-lang/rustup@ce3c09a

Fixes rust-lang#125809
@rezwanahmedsami
Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs
803cbaf
@rezwanahmedsami
Added #[cfg(target_arch = x86_64)] to f16 and f128
9f39427
@ChrisDenton
Test wholearchive on rust staticlib
76fbf0a
@ChrisDenton
Make import libraries compatible with wholearchive
40af214
@cjgillot
Use a LocalDefId in ResolvedArg.
c51f2d2
@Amjad50
Update compiler_builtins to 0.1.120
57b164a 
Signed-off-by: Amjad Alsharafi <26300843+Amjad50@users.noreply.github.com>
@tgross35
Rollup merge of rust-lang#126985 - Mrmaxmeier:dwarf-embed-source, r=d…
c6d3a99 
…avidtwco

Implement `-Z embed-source` (DWARFv5 source code embedding extension)

Implement rust-lang/compiler-team#764 MCP which adds an unstable flag that exposes LLVM's [DWARFv5 source code embedding](https://dwarfstd.org/issues/180201.1.html) support.
@tgross35
Rollup merge of rust-lang#128349 - tgross35:x86-f16, r=Noratrieb
b986d9b 
Enable `f16` on x86 and x86-64

Since the `compiler_builtins` update [1], ABI bugs on x86 should be resolved. Enable tests for f16 on these platforms now.

[1]: rust-lang#125016

try-job: i686-gnu
try-job: dist-i586-gnu-i586-i686-musl
@tgross35
Rollup merge of rust-lang#128876 - ColinFinck:rust-lld-with-runtime-d…
75fbcac 
…lls, r=Kobzol,petrochenkov,jieyouxu

Ship MinGW-w64 runtime DLLs along with `rust-lld.exe` for `-pc-windows-gnu` targets

`rust-lld.exe` built for `x86_64-pc-windows-gnu` depends on `libgcc_s_seh-1.dll` and `libwinpthread-1.dll` from MinGW-w64. Until now, they were not shipped alongside `rust-lld.exe`, and you could not run `rust-lld.exe` on most systems.

This problem didn't surface until now because:
* Most targets don't use `rust-lld` by default.
* Some people had these DLLs in their `PATH` from some other MinGW binary.
* `rustup` used to add `bin` to the `PATH`, which contains these DLLs for `rustc.exe`. But it no longer does that: rust-lang/rustup@ce3c09a

Fixes rust-lang#125809

try-job: dist-x86_64-mingw
@tgross35
Rollup merge of rust-lang#129190 - rezwanahmedsami:master, r=tgross35
d3d65dc 
Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs

Fixes rust-lang#129163

try-job: x86_64-msvc
try-job: x86_64-mingw
try-job: i686-msvc
try-job: i686-mingw
@tgross35
Rollup merge of rust-lang#129257 - ChrisDenton:rename-null-descriptor…
1531ca2 
…, r=jieyouxu

Allow rust staticlib to work with MSVC's /WHOLEARCHIVE

This fixes rust-lang#129020 by renaming the `__NULL_IMPORT_DESCRIPTOR` to prevent conflicts.

try-job: dist-i686-msvc
@tgross35
Rollup merge of rust-lang#129386 - cjgillot:local-resolved-arg, r=com…
a1d6403 
…piler-errors

Use a LocalDefId in ResolvedArg.
@tgross35
Rollup merge of rust-lang#129400 - Amjad50:update-compiler-builtins, …
56b3880 
…r=tgross35

Update `compiler_builtins` to `0.1.120`

Includes rust-lang/compiler-builtins#672 which fixes regression issue with Apple and Windows compilers.

r? `@tgross35`
@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Aug 22, 2024
@tgross35
Copy link
Contributor Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Aug 22, 2024

📌 Commit 56b3880 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2024
@bors
Copy link
Collaborator

bors commented Aug 22, 2024

⌛ Testing commit 56b3880 with merge be29189...

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 22, 2024
@bors
Auto merge of rust-lang#129407 - tgross35:rollup-q5vnsge, r=tgross35
be29189 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#126985 (Implement `-Z embed-source` (DWARFv5 source code embedding extension))
 - rust-lang#128349 (Enable `f16` on x86 and x86-64)
 - rust-lang#128876 (Ship MinGW-w64 runtime DLLs along with `rust-lld.exe` for `-pc-windows-gnu` targets)
 - rust-lang#129190 (Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs)
 - rust-lang#129257 (Allow rust staticlib to work with MSVC's /WHOLEARCHIVE)
 - rust-lang#129386 (Use a LocalDefId in ResolvedArg.)
 - rust-lang#129400 (Update `compiler_builtins` to `0.1.120`)

r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-distcheck failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Aug 22, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 22, 2024
@Mrmaxmeier
Copy link
Contributor

The job x86_64-gnu-distcheck failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)

Not sure why the bot's log is empty but seems like this is #128349


2024-08-22T14:12:37.7228527Z failures:
2024-08-22T14:12:37.7228791Z 
2024-08-22T14:12:37.7229764Z ---- std/src/f16.rs - f16::f16::hypot (line 712) stdout ----
2024-08-22T14:12:37.7232640Z rustc: /checkout/src/llvm-project/llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:4663: void {anonymous}::SelectionDAGLegalize::ConvertNodeToLibcall(llvm::SDNode*): Assertion `LC != RTLIB::UNKNOWN_LIBCALL && "Unexpected fpowi."' failed.
2024-08-22T14:12:37.7234842Z Couldn't compile the test.
2024-08-22T14:12:37.7235393Z ---- std/src/f16.rs - f16::f16::tanh (line 1155) stdout ----
2024-08-22T14:12:37.7237001Z rustc: /checkout/src/llvm-project/llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:4663: void {anonymous}::SelectionDAGLegalize::ConvertNodeToLibcall(llvm::SDNode*): Assertion `LC != RTLIB::UNKNOWN_LIBCALL && "Unexpected fpowi."' failed.
2024-08-22T14:12:37.7238309Z Couldn't compile the test.
2024-08-22T14:12:37.7238524Z 
2024-08-22T14:12:37.7238642Z failures:
2024-08-22T14:12:37.7239022Z     std/src/f16.rs - f16::f16::hypot (line 712)
2024-08-22T14:12:37.7239533Z     std/src/f16.rs - f16::f16::tanh (line 1155)

@tgross35 tgross35 mentioned this pull request Aug 22, 2024
Merged
@tgross35
Copy link
Contributor Author

tgross35 commented Aug 22, 2024 •
edited
Loading

Thanks for looking, I r-ed that PR. Seems like a llvm exception, weird.

I don't know why but the bot's logs don't always seem to populate.

@tgross35 tgross35 closed this Aug 22, 2024
@tgross35 tgross35 deleted the rollup-q5vnsge branch August 22, 2024 14:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-run-make Area: port run-make Makefiles to rmake.rs rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@tgross35 @bors @rust-log-analyzer @Mrmaxmeier @rustbot @ColinFinck @rezwanahmedsami @ChrisDenton @cjgillot @Amjad50