Skip to content

Don't trigger refinement lint if predicates reference errors #129417

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2024
Merged

Don't trigger refinement lint if predicates reference errors #129417

merged 1 commit into from
Aug 23, 2024

Conversation

compiler-errors
Copy link
Member

Fixes #129404

@rustbot
Copy link
Collaborator

rustbot commented Aug 22, 2024

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 22, 2024
@lqd
Copy link
Member

lqd commented Aug 22, 2024

(hehe I wanted to fix that issue) r=me when CI is green

@compiler-errors
Copy link
Member Author

@lqd: if you see an issue that you want to fix, feel free to claim it. if you can't get it working or don't have the time, you can always unclaim it.

@bors r=lqd rollup

@bors
Copy link
Collaborator

bors commented Aug 22, 2024

📌 Commit 8eb1558 has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 22, 2024
@matthiaskrgr
Rollup merge of rust-lang#129417 - compiler-errors:refine-err, r=lqd
424222d 
Don't trigger refinement lint if predicates reference errors

Fixes rust-lang#129404
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 22, 2024
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 22, 2024
@matthiaskrgr
Rollup merge of rust-lang#129417 - compiler-errors:refine-err, r=lqd
bdc2db8 
Don't trigger refinement lint if predicates reference errors

Fixes rust-lang#129404
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 22, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 23, 2024
@bors
Auto merge of rust-lang#129428 - matthiaskrgr:rollup-464enhe, r=matth…
01c5a90 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#126985 (Implement `-Z embed-source` (DWARFv5 source code embedding extension))
 - rust-lang#128511 (Document WebAssembly target feature expectations)
 - rust-lang#128935 (More work on `zstd` compression)
 - rust-lang#129263 (Add a missing compatibility note in the 1.80.0 release notes)
 - rust-lang#129386 (Use a LocalDefId in ResolvedArg.)
 - rust-lang#129408 (Fix handling of macro arguments within the `dropping_copy_types` lint)
 - rust-lang#129417 (Don't trigger refinement lint if predicates reference errors)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 23, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 23, 2024
@bors
Auto merge of rust-lang#129443 - matthiaskrgr:rollup-tbgdj0p, r=matth…
087fc49 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#127623 (fix: fs::remove_dir_all: treat internal ENOENT as success)
 - rust-lang#128876 (Ship MinGW-w64 runtime DLLs along with `rust-lld.exe` for `-pc-windows-gnu` targets)
 - rust-lang#129055 (Migrate `x86_64-fortanix-unknown-sgx-lvi` `run-make` test to rmake)
 - rust-lang#129386 (Use a LocalDefId in ResolvedArg.)
 - rust-lang#129400 (Update `compiler_builtins` to `0.1.120`)
 - rust-lang#129414 (Fix extern crates not being hidden with `doc(hidden)`)
 - rust-lang#129417 (Don't trigger refinement lint if predicates reference errors)
 - rust-lang#129433 (Fix a missing import in a doc in run-make-support)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 23, 2024
@bors
Auto merge of rust-lang#129443 - matthiaskrgr:rollup-tbgdj0p, r=matth…
c8b14ba 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#127623 (fix: fs::remove_dir_all: treat internal ENOENT as success)
 - rust-lang#128876 (Ship MinGW-w64 runtime DLLs along with `rust-lld.exe` for `-pc-windows-gnu` targets)
 - rust-lang#129055 (Migrate `x86_64-fortanix-unknown-sgx-lvi` `run-make` test to rmake)
 - rust-lang#129386 (Use a LocalDefId in ResolvedArg.)
 - rust-lang#129400 (Update `compiler_builtins` to `0.1.120`)
 - rust-lang#129414 (Fix extern crates not being hidden with `doc(hidden)`)
 - rust-lang#129417 (Don't trigger refinement lint if predicates reference errors)
 - rust-lang#129433 (Fix a missing import in a doc in run-make-support)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 32821b9 into rust-lang:master Aug 23, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 23, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 23, 2024
@rust-timer
Unrolled build for rust-lang#129417
90580da 
Rollup merge of rust-lang#129417 - compiler-errors:refine-err, r=lqd

Don't trigger refinement lint if predicates reference errors

Fixes rust-lang#129404
@zbowling zbowling mentioned this pull request Dec 30, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.

refining_impl_trait suggestion in invalid code
5 participants
@compiler-errors @rustbot @lqd @bors @cjgillot