Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Create opaque definitions in resolver. #129493

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

cjgillot
Copy link
Contributor

Implementing #129023 (comment)

That was easier than I expected.

r? @petrochenkov

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 24, 2024
@rust-log-analyzer

This comment has been minimized.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2024
@cjgillot cjgillot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 31, 2024
@petrochenkov
Copy link
Contributor

r=me after squashing.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2024
}
}
ExprKind::Gen(_, _, _, _) => {
ExprKind::Closure(..) | ExprKind::Gen(..) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I simplified the Closure arm to just create the def-id, like other branches do. There is no additional behaviour change.

@cjgillot
Copy link
Contributor Author

cjgillot commented Sep 1, 2024

@bors r=petrochenkov

@bors
Copy link
Contributor

bors commented Sep 1, 2024

📌 Commit f68f665 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 1, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 1, 2024
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#128495 (core: use `compare_bytes` for more slice element types)
 - rust-lang#128641 (refactor: standardize duplicate processes in parser)
 - rust-lang#129207 (Lint that warns when an elided lifetime ends up being a named lifetime)
 - rust-lang#129493 (Create opaque definitions in resolver.)
 - rust-lang#129619 (Update stacker to 0.1.17)
 - rust-lang#129672 (Make option-like-enum.rs UB-free and portable)
 - rust-lang#129780 (add crashtests for several old unfixed ICEs)
 - rust-lang#129832 (Remove stray dot in `std::char::from_u32_unchecked` documentation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 07d5c25 into rust-lang:master Sep 1, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Sep 1, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 1, 2024
Rollup merge of rust-lang#129493 - cjgillot:early-opaque-def, r=petrochenkov

Create opaque definitions in resolver.

Implementing rust-lang#129023 (comment)

That was easier than I expected.

r? `@petrochenkov`
@cjgillot cjgillot deleted the early-opaque-def branch September 1, 2024 11:48
@cuviper cuviper removed this from the 1.82.0 milestone Sep 5, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants