Skip to content

run_make_support: rename Command::stdin to stdin_buf and add std{in,out,err} config helpers #129973

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 5, 2024
Merged

run_make_support: rename Command::stdin to stdin_buf and add std{in,out,err} config helpers #129973

merged 3 commits into from
Sep 5, 2024

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Sep 5, 2024

Previously Command::stdin was actually just a stdin buffer helper, but
this is different from std::process::Command::stdin. This is
needlessly confusing, and blocks support to add std{in,out,err} config
helpers that tests may want to use to e.g. redirect to /dev/ptmx.

@rustbot
Copy link
Collaborator

rustbot commented Sep 5, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2024
@jieyouxu
Copy link
Member Author

jieyouxu commented Sep 5, 2024

r? @Kobzol since you're familiar with the Command wrapper abstractions

@rustbot rustbot assigned Kobzol and unassigned Mark-Simulacrum Sep 5, 2024
@rust-log-analyzer

This comment has been minimized.

# to view
@rust-log-analyzer

This comment has been minimized.

# to view
@jieyouxu
run_make_support: rename Command::stdin to stdin_buf and add `std…
2031eac 
…{in,out,err}` config helpers

Previously `Command::stdin` was actually just a stdin buffer helper, but
this is different from `std::process::Command::stdin`. This is
needlessly confusing, and blocks support to add `std{in,out,err}` config
that tests may want to use to e.g. redirect to `/dev/ptmx`.
@jieyouxu
tests: use renamed stdin_buf
afed862
@jieyouxu jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2024
@jieyouxu jieyouxu changed the title run_make_support: rename Command::stdin to stdin_buf and add std{in,out,err} config helpers run_make_support: rename Command::stdin to stdin_buf and add std{in,out,err} config helpers Sep 5, 2024
@jieyouxu jieyouxu changed the title run_make_support: rename Command::stdin to stdin_buf and add std{in,out,err} config helpers run_make_support: rename Command::stdin to stdin_buf and add std{in,out,err} config helpers Sep 5, 2024
@Kobzol
Copy link
Contributor

Kobzol commented Sep 5, 2024

Thanks. You can r=me once CI is green.

@jieyouxu
Copy link
Member Author

jieyouxu commented Sep 5, 2024

@bors r=@Kobzol rollup

@bors
Copy link
Collaborator

bors commented Sep 5, 2024

📌 Commit 8871ce0 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 5, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 5, 2024
@matthiaskrgr
Rollup merge of rust-lang#129973 - jieyouxu:rework-rmake-stdio, r=Kobzol
0be10be 
run_make_support: rename `Command::stdin` to `stdin_buf` and add `std{in,out,err}` config helpers

Previously `Command::stdin` was actually just a stdin buffer helper, but
this is different from `std::process::Command::stdin`. This is
needlessly confusing, and blocks support to add `std{in,out,err}` config
helpers that tests may want to use to e.g. redirect to `/dev/ptmx`.
This was referenced Sep 5, 2024
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 5, 2024
@bors
Auto merge of rust-lang#129994 - matthiaskrgr:rollup-zkj4ekl, r=matth…
ddf70f1 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#128820 (fix: get llvm type of global val)
 - rust-lang#129028 (`impl_trait_overcaptures`: Don't worry about uncaptured contravariant lifetimes if they outlive a captured lifetime)
 - rust-lang#129471 ([rustdoc] Sort impl associated items by kinds and then by appearance)
 - rust-lang#129706 (Rename dump of coroutine by-move-body to be more consistent, fix ICE in dump_mir)
 - rust-lang#129720 (Simplify DestProp memory management)
 - rust-lang#129796 (Unify scraped examples with other code examples)
 - rust-lang#129938 (Elaborate on deriving vs implementing `Copy`)
 - rust-lang#129973 (run_make_support: rename `Command::stdin` to `stdin_buf` and add `std{in,out,err}` config helpers)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 5, 2024
@bors
Auto merge of rust-lang#129994 - matthiaskrgr:rollup-zkj4ekl, r=matth…
9c01301 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#128820 (fix: get llvm type of global val)
 - rust-lang#129028 (`impl_trait_overcaptures`: Don't worry about uncaptured contravariant lifetimes if they outlive a captured lifetime)
 - rust-lang#129471 ([rustdoc] Sort impl associated items by kinds and then by appearance)
 - rust-lang#129706 (Rename dump of coroutine by-move-body to be more consistent, fix ICE in dump_mir)
 - rust-lang#129720 (Simplify DestProp memory management)
 - rust-lang#129796 (Unify scraped examples with other code examples)
 - rust-lang#129938 (Elaborate on deriving vs implementing `Copy`)
 - rust-lang#129973 (run_make_support: rename `Command::stdin` to `stdin_buf` and add `std{in,out,err}` config helpers)

r? `@ghost`
`@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 5, 2024
@rust-timer
Unrolled build for rust-lang#129973
458e4c8 
Rollup merge of rust-lang#129973 - jieyouxu:rework-rmake-stdio, r=Kobzol

run_make_support: rename `Command::stdin` to `stdin_buf` and add `std{in,out,err}` config helpers

Previously `Command::stdin` was actually just a stdin buffer helper, but
this is different from `std::process::Command::stdin`. This is
needlessly confusing, and blocks support to add `std{in,out,err}` config
helpers that tests may want to use to e.g. redirect to `/dev/ptmx`.
@bors bors merged commit fee6c0a into rust-lang:master Sep 5, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 5, 2024
@jieyouxu jieyouxu deleted the rework-rmake-stdio branch October 21, 2024 08:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Kobzol Kobzol Kobzol left review comments

Assignees

@Kobzol Kobzol

Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
No open projects
Oxidizing run-make tests
Status: Done
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jieyouxu @rustbot @rust-log-analyzer @Kobzol @bors @Mark-Simulacrum