Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove the unused llvm-skip-rebuild option from x.py #130059

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Remove the unused llvm-skip-rebuild option from x.py #130059

merged 1 commit into from
Sep 8, 2024

Conversation

gurry
Copy link
Contributor

@gurry gurry commented Sep 7, 2024

Fixes #130039

@rustbot
Copy link
Collaborator

rustbot commented Sep 7, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Sep 7, 2024

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 7, 2024
Kobzol
Kobzol approved these changes Sep 7, 2024
View reviewed changes
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Since this was no longer exposed in config.toml, I don't think that it needs a bootstrap change tracker entry. I wonder why the field was not flagged as unused though...

@Kobzol
Copy link
Contributor

Kobzol commented Sep 7, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 7, 2024

📌 Commit 11ee513 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2024
@gurry gurry changed the title Remove the unused llvm-skip-rebild option from x.py Remove the unused llvm-skip-rebuild option from x.py Sep 7, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 7, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 7, 2024
@bors
Auto merge of rust-lang#130091 - matthiaskrgr:rollup-kalu1cs, r=matth…
878f49f 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#126452 (Implement raw lifetimes and labels (`'r#ident`))
 - rust-lang#129555 (stabilize const_float_bits_conv)
 - rust-lang#129594 (explain the options bootstrap passes to curl)
 - rust-lang#129677 (Don't build by-move body when async closure is tainted)
 - rust-lang#129847 (Do not call query to compute coroutine layout for synthetic body of async closure)
 - rust-lang#129869 (add a few more crashtests)
 - rust-lang#130009 (rustdoc-search: allow trailing `Foo ->` arg search)
 - rust-lang#130046 (str: make as_mut_ptr and as_bytes_mut unstably const)
 - rust-lang#130047 (Win: Add dbghelp to the list of import libraries)
 - rust-lang#130059 (Remove the unused  `llvm-skip-rebuild` option from x.py)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4ba483d into rust-lang:master Sep 8, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 8, 2024
@rust-timer
Unrolled build for rust-lang#130059
f0e4543 
Rollup merge of rust-lang#130059 - gurry:130039-remove-skip-rebuild, r=Kobzol

Remove the unused  `llvm-skip-rebuild` option from x.py

Fixes rust-lang#130039
@rustbot rustbot added this to the 1.83.0 milestone Sep 8, 2024
@gurry gurry deleted the 130039-remove-skip-rebuild branch September 8, 2024 03:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Kobzol Kobzol Kobzol approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.

x.py refers to skip-build, which is missing from config.example.toml
5 participants
@gurry @rustbot @Kobzol @bors @Mark-Simulacrum