-
Notifications
You must be signed in to change notification settings - Fork 13.4k
avoid updating LLVM submodule during bootstrap unit tests #130306
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
avoid updating LLVM submodule during bootstrap unit tests #130306
Conversation
rustbot has assigned @albertlarsan68. Use |
This PR modifies If appropriate, please update |
Could we use a hard-coded config.toml file (string) for unit tests, to avoid sprinkling these cfg gates throughout bootstrap's codebase? |
We don't use a consistent configuration for all unit tests, which is the problem. You can find some examples in the config test module. |
Hmm, yeah, that might better be refactored to share some default test configuration, but that's a bigger change. You can r=me if CI is green. But CI checks out all submodules anyway, so I don't expect that this should break bootstrap tests. I tried to deinit all submodules locally and bootstrap tests were also green. |
I guess that can't help either as we intentionally set some options to test them. @bors r=Kobzol |
This seems to not work if you don't have the submodules already checked out. There are some steps that require submodules to exist. This PR causes failures like:
To reproduce:
|
Hmm, I guess for now we should only ignore @bors r- |
Interesting, I did the same (just deinited the submodules after checking out this PR), and it worked for me 🤔 |
Signed-off-by: onur-ozkan <work@onurozkan.dev>
2af4636
to
f03bfb8
Compare
@rustbot ready |
@bors r+ |
Rollup of 5 pull requests Successful merges: - rust-lang#130138 (bootstrap: Print more debug info when `find_initial_libdir` fails) - rust-lang#130199 (Don't call closure_by_move_body_def_id on FnOnce async closures in MIR validation) - rust-lang#130302 (add llvm-bitcode-linker and llvm-tools bins to ci-rustc's sysroot) - rust-lang#130306 (avoid updating LLVM submodule during bootstrap unit tests) - rust-lang#130317 (`ProjectionElem` and `UnOp`/`BinOp` dont need to be `PartialOrd`/`Ord`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup of 5 pull requests Successful merges: - rust-lang#130138 (bootstrap: Print more debug info when `find_initial_libdir` fails) - rust-lang#130199 (Don't call closure_by_move_body_def_id on FnOnce async closures in MIR validation) - rust-lang#130302 (add llvm-bitcode-linker and llvm-tools bins to ci-rustc's sysroot) - rust-lang#130306 (avoid updating LLVM submodule during bootstrap unit tests) - rust-lang#130317 (`ProjectionElem` and `UnOp`/`BinOp` dont need to be `PartialOrd`/`Ord`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#130306 - onur-ozkan:avoid-submodule-updates-in-tests, r=Kobzol avoid updating LLVM submodule during bootstrap unit tests To test this, make sure you don't have `src/llvm-project` fetched and then set `llvm.download-ci-llvm=true` and run `x test bootstrap`.
To test this, make sure you don't have
src/llvm-project
fetched and then setllvm.download-ci-llvm=true
and runx test bootstrap
.