Skip to content

Add myself to the libs review rotation #130499

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2024
Merged

Add myself to the libs review rotation #130499

merged 2 commits into from
Sep 18, 2024

Conversation

ibraheemdev
Copy link
Member

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Sep 18, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 18, 2024

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@Noratrieb
Copy link
Member

borsrplus in the style of the ToysRUs logo

@bors
Copy link
Collaborator

bors commented Sep 18, 2024

📌 Commit f522327 has been approved by Noratrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2024
@Noratrieb
Copy link
Member

thanks :3

@matthiaskrgr matthiaskrgr mentioned this pull request Sep 18, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 18, 2024
@bors
Auto merge of rust-lang#130500 - matthiaskrgr:rollup-lfx3bb4, r=matth…
82d17a4 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#130466 (tests: add repr/transparent test for aarch64)
 - rust-lang#130468 (Make sure that def id <=> lang item map is bidirectional)
 - rust-lang#130499 (Add myself to the libs review rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d20649e into rust-lang:master Sep 18, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 18, 2024
@rust-timer
Unrolled build for rust-lang#130499
364d1de 
Rollup merge of rust-lang#130499 - ibraheemdev:libs-review, r=Noratrieb

Add myself to the libs review rotation
@rustbot rustbot added this to the 1.83.0 milestone Sep 18, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ibraheemdev @rustbot @Noratrieb @bors @Mark-Simulacrum