Generate line numbers for non-rust code examples as well #130664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
generate-line-numbers-on-non-rust
branch
from
06b549d to
11e848f
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
generate-line-numbers-on-non-rust
branch
from
11e848f to
f451a41
Compare
|
I agree. It is strange. @bors r+ rollup |
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 22, 2024
…rs-on-non-rust, r=notriddle Generate line numbers for non-rust code examples as well Currently, the "enable line numbers" setting only generated it for rust code examples. Found this limitation a bit strange so I decided to remove it. You can test it [here](https://rustdoc.crud.net/imperio/generate-line-number-non-rust/doc/lib2/sub_mod/struct.Foo.html). r? `@notriddle`
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 22, 2024
…rs-on-non-rust, r=notriddle Generate line numbers for non-rust code examples as well Currently, the "enable line numbers" setting only generated it for rust code examples. Found this limitation a bit strange so I decided to remove it. You can test it [here](https://rustdoc.crud.net/imperio/generate-line-number-non-rust/doc/lib2/sub_mod/struct.Foo.html). r? `@notriddle`
This was referenced Sep 22, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2024
…kingjubilee Rollup of 5 pull requests Successful merges: - rust-lang#130648 (move enzyme flags from general cargo to rustc-specific cargo) - rust-lang#130650 (Fixup Apple target's description strings) - rust-lang#130664 (Generate line numbers for non-rust code examples as well) - rust-lang#130665 (Prevent Deduplication of `LongRunningWarn`) - rust-lang#130669 (tests: Test that `extern "C" fn` ptrs lint on slices) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2024
Rollup merge of rust-lang#130664 - GuillaumeGomez:generate-line-numbers-on-non-rust, r=notriddle Generate line numbers for non-rust code examples as well Currently, the "enable line numbers" setting only generated it for rust code examples. Found this limitation a bit strange so I decided to remove it. You can test it [here](https://rustdoc.crud.net/imperio/generate-line-number-non-rust/doc/lib2/sub_mod/struct.Foo.html). r? ``@notriddle``
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the "enable line numbers" setting only generated it for rust code examples. Found this limitation a bit strange so I decided to remove it.
You can test it here.
r? @notriddle