Compiler: Rename "object safe" to "dyn compatible" #130826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmease
added
the
S-waiting-on-fcp
rustbot
added
PG-exploit-mitigations
fmease
added
the
rla-silenced
fmease
force-pushed
the
compiler-mv-obj-safe-dyn-compat
branch
from
236e368 to
f874dfd
Compare
fmease
force-pushed
the
compiler-mv-obj-safe-dyn-compat
branch
from
f874dfd to
01a063f
Compare
12 tasks
fmease
removed
the
S-waiting-on-fcp
fmease
changed the title
|
Some changes occurred in src/librustdoc/clean/types.rs cc @camelid changes to the core type system Some changes occurred in diagnostic error codes This PR changes Stable MIR cc @oli-obk, @celinval, @ouz-a Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor Some changes occurred in compiler/rustc_sanitizers cc @rust-lang/project-exploit-mitigations, @rcvalle |
|
r? compiler |
|
LGTM. I reviewed this mostly by reverting the major rename changes and then reviewing the remainder of the diff. @bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 27, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#130718 (Cleanup some known-bug issues) - rust-lang#130730 (Reorganize Test Headers) - rust-lang#130826 (Compiler: Rename "object safe" to "dyn compatible") - rust-lang#130915 (fix typo in triagebot.toml) - rust-lang#130926 (Update cc to 1.1.22 in library/) - rust-lang#130932 (etc: Add sample rust-analyzer configs for eglot & helix) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 27, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#130718 (Cleanup some known-bug issues) - rust-lang#130730 (Reorganize Test Headers) - rust-lang#130826 (Compiler: Rename "object safe" to "dyn compatible") - rust-lang#130915 (fix typo in triagebot.toml) - rust-lang#130926 (Update cc to 1.1.22 in library/) - rust-lang#130932 (etc: Add sample rust-analyzer configs for eglot & helix) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 27, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#130718 (Cleanup some known-bug issues) - rust-lang#130730 (Reorganize Test Headers) - rust-lang#130826 (Compiler: Rename "object safe" to "dyn compatible") - rust-lang#130915 (fix typo in triagebot.toml) - rust-lang#130926 (Update cc to 1.1.22 in library/) - rust-lang#130932 (etc: Add sample rust-analyzer configs for eglot & helix) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 28, 2024
Rollup merge of rust-lang#130826 - fmease:compiler-mv-obj-safe-dyn-compat, r=compiler-errors Compiler: Rename "object safe" to "dyn compatible" Completed T-lang FCP: rust-lang/lang-team#286 (comment). Tracking issue: rust-lang#130852 Excludes `compiler/rustc_codegen_cranelift` (to be filed separately). Includes Stable MIR. Regarding https://github.com/rust-lang/rust/labels/relnotes, I guess I will manually open a https://github.com/rust-lang/rust/labels/relnotes-tracking-issue since this change affects everything (compiler, library, tools, docs, books, everyday language). r? ghost
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 10, 2024
…mpat-2, r=jieyouxu Compiler & its UI tests: Rename remaining occurrences of "object safe" to "dyn compatible" Follow-up to rust-lang#130826. Part of rust-lang#130852. 1. 1st commit: Fix stupid oversights. Should've been part of rust-lang#130826. 2. 2nd commit: Rename the unstable feature `object_safe_for_dispatch` to `dyn_compatible_for_dispatch`. Might not be worth the churn, you decide. 3. 3rd commit: Apply the renaming to all UI tests (contents and paths).
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 10, 2024
…mpat-2, r=jieyouxu Compiler & its UI tests: Rename remaining occurrences of "object safe" to "dyn compatible" Follow-up to rust-lang#130826. Part of rust-lang#130852. 1. 1st commit: Fix stupid oversights. Should've been part of rust-lang#130826. 2. 2nd commit: Rename the unstable feature `object_safe_for_dispatch` to `dyn_compatible_for_dispatch`. Might not be worth the churn, you decide. 3. 3rd commit: Apply the renaming to all UI tests (contents and paths).
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 10, 2024
…mpat-2, r=jieyouxu Compiler & its UI tests: Rename remaining occurrences of "object safe" to "dyn compatible" Follow-up to rust-lang#130826. Part of rust-lang#130852. 1. 1st commit: Fix stupid oversights. Should've been part of rust-lang#130826. 2. 2nd commit: Rename the unstable feature `object_safe_for_dispatch` to `dyn_compatible_for_dispatch`. Might not be worth the churn, you decide. 3. 3rd commit: Apply the renaming to all UI tests (contents and paths).
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Oct 10, 2024
…mpat-2, r=jieyouxu Compiler & its UI tests: Rename remaining occurrences of "object safe" to "dyn compatible" Follow-up to rust-lang#130826. Part of rust-lang#130852. 1. 1st commit: Fix stupid oversights. Should've been part of rust-lang#130826. 2. 2nd commit: Rename the unstable feature `object_safe_for_dispatch` to `dyn_compatible_for_dispatch`. Might not be worth the churn, you decide. 3. 3rd commit: Apply the renaming to all UI tests (contents and paths).
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 10, 2024
…mpat-2, r=jieyouxu Compiler & its UI tests: Rename remaining occurrences of "object safe" to "dyn compatible" Follow-up to rust-lang#130826. Part of rust-lang#130852. 1. 1st commit: Fix stupid oversights. Should've been part of rust-lang#130826. 2. 2nd commit: Rename the unstable feature `object_safe_for_dispatch` to `dyn_compatible_for_dispatch`. Might not be worth the churn, you decide. 3. 3rd commit: Apply the renaming to all UI tests (contents and paths).
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 10, 2024
Rollup merge of rust-lang#131475 - fmease:compiler-mv-obj-safe-dyn-compat-2, r=jieyouxu Compiler & its UI tests: Rename remaining occurrences of "object safe" to "dyn compatible" Follow-up to rust-lang#130826. Part of rust-lang#130852. 1. 1st commit: Fix stupid oversights. Should've been part of rust-lang#130826. 2. 2nd commit: Rename the unstable feature `object_safe_for_dispatch` to `dyn_compatible_for_dispatch`. Might not be worth the churn, you decide. 3. 3rd commit: Apply the renaming to all UI tests (contents and paths).
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 31, 2025
…mpat-ii, r=jieyouxu Compiler: Finalize dyn compatibility renaming Update the Reference link to use the new URL fragment from rust-lang/reference#1666 (this change has finally hit stable). Fixes a FIXME. Follow-up to rust-lang#130826. Part of rust-lang#130852. ~~Blocking it on rust-lang#133372.~~ (merged) r? ghost
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 31, 2025
Rollup merge of rust-lang#135860 - fmease:compiler-mv-obj-save-dyn-compat-ii, r=jieyouxu Compiler: Finalize dyn compatibility renaming Update the Reference link to use the new URL fragment from rust-lang/reference#1666 (this change has finally hit stable). Fixes a FIXME. Follow-up to rust-lang#130826. Part of rust-lang#130852. ~~Blocking it on rust-lang#133372.~~ (merged) r? ghost
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed T-lang FCP: rust-lang/lang-team#286 (comment).
Tracking issue: #130852
Excludes
compiler/rustc_codegen_cranelift(to be filed separately).Includes Stable MIR.
Regarding relnotesMarks issues that should be documented in the release notes of the next release.
, I guess I will manually open a
relnotes-tracking-issue
Marks issues tracking what text to put in release notes.
since this change affects everything (compiler, library, tools, docs, books, everyday language).
r? ghost