Rollup of 11 pull requests #130907
Merged
Rollup of 11 pull requests #130907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Drop implementation
This accessibility improvement gates the target flashing and tooltip fade-out behind an inverted prefers-reduced-motion media query.
…homcc,traviscross Document subtleties of `ManuallyDrop` After seeing rust-lang#130140 and rust-lang#130141, I figured that `ManuallyDrop` needs documentation explaining its subtleties, hence this PR. See also rust-lang/unsafe-code-guidelines#245
Add the library workspace to the suggested rust-analyzer config
…mpiler-errors
Fix diagnostics for coroutines with () as input.
This may be a more real-life example to trigger the diagnostic:
```rust
#![features(try_blocks, coroutine_trait, coroutines)]
use std::ops::Coroutine;
struct Request;
struct Response;
fn get_args() -> Result<String, String> { todo!() }
fn build_request(_arg: String) -> Request { todo!() }
fn work() -> impl Coroutine<Option<Response>, Yield = Request> {
#[coroutine]
|_| {
let r: Result<(), String> = try {
let req = get_args()?;
yield build_request(req)
};
if let Err(msg) = r {
eprintln!("Error: {msg}");
}
}
}
```
…,fee1-dead Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation Closes: rust-lang#130430 r? rust-lang/diagnostics
Utf8Chunks: add link to Utf8Chunk It is currently surprisingly non-trivial to go from the `utf8_chunks` method to the docs of the `valid`/`invalid` methods used in the example. This should help.
…rumentations, r=nikic Pass Module Analysis Manager to Standard Instrumentations This PR introduces changes related to llvm::PassInstrumentationCallbacks. Now, we pass Module Analysis Manager to StandardInstrumentations::registerCallbacks, so it can take advantage of such instrumentations as IR verifier or preserved CFG checker. So basically this is NFC PR.
…mdev Use `mem::offset_of!` for `sockaddr_un.sun_path` We don't need manual pointer math here anymore! try-job: dist-i686-msvc
…laumeGomez rustdoc: do not animate :target when user prefers reduced motion This accessibility improvement gates rust-lang#129284 behind an inverted [prefers-reduced-motion](https://developer.mozilla.org/en-US/docs/Web/CSS/`@media/prefers-reduced-motion)` media query.
Update FIXME comment in s390x_unknown_linux_*.rs - Remove comment about "LLVM < 16" since the minimum external LLVM version is 16+ since rust-lang#117947 - Reflect rename of cabi_s390x.rs in rust-lang@030244c (renamed to [abi/call/s390x.rs](rust-lang@030244c#diff-20136d4a18fa0ef9bd4fc2e6f92e88daad6be88bfb156e5702af39ee87ca4879), and it is currently [still in the same location](https://github.com/rust-lang/rust/blob/9e394f551c050ff03c6fc57f190e0761cf0be6e8/compiler/rustc_target/src/abi/call/s390x.rs)). r? ``````@cuviper`````` ``````@rustbot`````` label +O-SystemZ
…rors Pass correct HirId to late_bound_vars in diagnostic code Fixes rust-lang#130858. Fixes rust-lang#125655. Fixes rust-lang#130391. Fixes rust-lang#130663. r? compiler-errors
add missing FIXME(const-hack) r? ```@scottmcm```
rustbot
added
O-unix
rustbot
added
T-compiler
|
@bors r+ p=10 rollup=never |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 2bd1e894ef In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (58420a0): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -1.5%, secondary -1.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 774.091s -> 774.44s (0.05%) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
ManuallyDrop#130279 (Document subtleties ofManuallyDrop)let_underscore_dropon type withoutDropimplementation #130833 (Fix the misleading diagnostic forlet_underscore_dropon type withoutDropimplementation)mem::offset_of!forsockaddr_un.sun_path#130861 (Usemem::offset_of!forsockaddr_un.sun_path)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup