Skip to content

compiletest: rename "runtest/crash.rs" to "runtest/crashes.rs" to be in line with the test directory #130973

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2024
Merged

compiletest: rename "runtest/crash.rs" to "runtest/crashes.rs" to be in line with the test directory #130973

merged 1 commit into from
Sep 28, 2024

Conversation

matthiaskrgr
Copy link
Member

r? jieyouxu

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 28, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 28, 2024

Some changes occurred in src/tools/compiletest

cc @jieyouxu

jieyouxu
jieyouxu approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right I wanted to change that too but forgor. Thanks!

@jieyouxu
Copy link
Member

r=me after PR CI is green.

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 28, 2024

📌 Commit 84c944c has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2024
@jieyouxu jieyouxu added the A-compiletest Area: The compiletest test runner label Sep 28, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 28, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 28, 2024
@bors
Auto merge of rust-lang#130979 - matthiaskrgr:rollup-u7ylca5, r=matth…
e6eb451 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#128778 (atomics: allow atomic and non-atomic reads to race)
 - rust-lang#130918 (simplify LLVM submodule handling)
 - rust-lang#130960 (Only add an automatic SONAME for Rust dylibs)
 - rust-lang#130973 (compiletest: rename "runtest/crash.rs" to "runtest/crashes.rs" to be in line with the test directory)
 - rust-lang#130976 (remove couple redundant clones)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1d29bfc into rust-lang:master Sep 28, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 28, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 28, 2024
@rust-timer
Unrolled build for rust-lang#130973
fc76bb2 
Rollup merge of rust-lang#130973 - matthiaskrgr:crash_rename, r=jieyouxu

compiletest: rename "runtest/crash.rs" to "runtest/crashes.rs" to be in line with the test directory

r? jieyouxu
@matthiaskrgr matthiaskrgr deleted the crash_rename branch January 25, 2025 09:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
No open projects
compiletest maintenance and improvements
Status: Done
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
4 participants
@matthiaskrgr @rustbot @jieyouxu @bors