Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

extend comment in global_llvm_features regarding target-cpu=native #131010

Merged
merged 1 commit into from
Sep 29, 2024
Merged

extend comment in global_llvm_features regarding target-cpu=native #131010

merged 1 commit into from
Sep 29, 2024

Conversation

RalfJung
Copy link
Member

Based on the description in #83084 by @nagisa -- seems better to have this in the code, where it is easier to find.

@rustbot
Copy link
Collaborator

rustbot commented Sep 29, 2024

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 29, 2024
jieyouxu
jieyouxu approved these changes Sep 29, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 29, 2024

📌 Commit a78fd69 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2024
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 29, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 29, 2024
@bors
Auto merge of rust-lang#131012 - GuillaumeGomez:rollup-e9ovh3a, r=Gui…
2da3cb9 
…llaumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#130383 (check if it's rust-lang/rust CI job in `llvm::is_ci_llvm_modified`)
 - rust-lang#130416 (resolve rust-lang#130122: reword 'sort-by' edge-conditions documentation)
 - rust-lang#130537 (rustdoc: add doc comment to DocVisitor)
 - rust-lang#130743 (Clarifications for set_nonblocking methods)
 - rust-lang#131010 (extend comment in global_llvm_features regarding target-cpu=native)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e9c9307 into rust-lang:master Sep 29, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 29, 2024
@rust-timer
Unrolled build for rust-lang#131010
ec2bc42 
Rollup merge of rust-lang#131010 - RalfJung:target-cpu-native, r=jieyouxu

extend comment in global_llvm_features regarding target-cpu=native

Based on the description in rust-lang#83084 by `@nagisa` -- seems better to have this in the code, where it is easier to find.
@rustbot rustbot added this to the 1.83.0 milestone Sep 29, 2024
@RalfJung RalfJung deleted the target-cpu-native branch September 30, 2024 09:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
4 participants
@RalfJung @rustbot @jieyouxu @bors