Skip to content

Improve implementations of UpperExp and LowerExp traits on integers #131149

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

GuillaumeGomez
Copy link
Member

Follow-up of #128204.

r? @workingjubilee

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 2, 2024
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
#16 2.903 Building wheels for collected packages: reuse
#16 2.904   Building wheel for reuse (pyproject.toml): started
#16 3.154   Building wheel for reuse (pyproject.toml): finished with status 'done'
#16 3.155   Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132715 sha256=dfa09868353292d98f811d3efdb0d54d07389e808efc71d68e3b93c514bf8bec
#16 3.155   Stored in directory: /tmp/pip-ephem-wheel-cache-0flylqbj/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#16 3.158 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#16 3.554 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#16 3.555 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#16 DONE 3.6s
---
...............................................

failures:

---- fmt::num::test_format_int_exp_limits stdout ----
thread 'fmt::num::test_format_int_exp_limits' panicked at core/src/fmt/num.rs:547:5:
attempt to subtract with overflow
---- fmt::num::test_format_int_exp_precision stdout ----
---- fmt::num::test_format_int_exp_precision stdout ----
thread 'fmt::num::test_format_int_exp_precision' panicked at core/src/fmt/num.rs:547:5:
attempt to subtract with overflow

failures:
    fmt::num::test_format_int_exp_limits
    fmt::num::test_format_int_exp_precision

@GuillaumeGomez
Copy link
Member Author

Checked more and it seems like the same strategy cannot be applied here.

@GuillaumeGomez GuillaumeGomez deleted the improve-upper-lower-exp branch October 2, 2024 11:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants