Skip to content

rustdoc: cleaner errors on disambiguator/namespace mismatches #131260

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2024
Merged

rustdoc: cleaner errors on disambiguator/namespace mismatches #131260

merged 1 commit into from
Oct 5, 2024

Conversation

notriddle
Copy link
Contributor

@rustbot
Copy link
Collaborator

rustbot commented Oct 4, 2024

Could not assign reviewer from: jyn514.
User(s) jyn514 are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

@rustbot
Copy link
Collaborator

rustbot commented Oct 4, 2024

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 4, 2024
@rust-log-analyzer

This comment has been minimized.

# to view
@notriddle notriddle force-pushed the notriddle/disambiguator-error branch from fa54567 to 3686e59 Compare October 4, 2024 16:56
jyn514
jyn514 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thanks!

@GuillaumeGomez
Copy link
Member

Thanks to both of you!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 4, 2024

📌 Commit 3686e59 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2024
@workingjubilee workingjubilee mentioned this pull request Oct 5, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 5, 2024
@bors
Auto merge of rust-lang#131275 - workingjubilee:rollup-4yxqio3, r=wor…
d30c392 
…kingjubilee

Rollup of 9 pull requests

Successful merges:

 - rust-lang#129517 (Compute array length from type for unconditional panic lint. )
 - rust-lang#130367 (Check elaborated projections from dyn don't mention unconstrained late bound lifetimes)
 - rust-lang#130403 (Stabilize `const_slice_from_raw_parts_mut`)
 - rust-lang#130633 (Add support for reborrowing pinned method receivers)
 - rust-lang#131105 (update `Literal`'s intro)
 - rust-lang#131194 (Fix needless_lifetimes in stable_mir)
 - rust-lang#131260 (rustdoc: cleaner errors on disambiguator/namespace mismatches)
 - rust-lang#131267 (Stabilize `BufRead::skip_until`)
 - rust-lang#131273 (Account for `impl Trait {` when `impl Trait for Type {` was intended)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f66aa60 into rust-lang:master Oct 5, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Oct 5, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 5, 2024
@rust-timer
Unrolled build for rust-lang#131260
7778b4e 
Rollup merge of rust-lang#131260 - notriddle:notriddle/disambiguator-error, r=GuillaumeGomez

rustdoc: cleaner errors on disambiguator/namespace mismatches

Resolves rust-lang#131224 (review)

r? `@jyn514`
@notriddle notriddle deleted the notriddle/disambiguator-error branch October 5, 2024 14:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

@jyn514 jyn514 jyn514 approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
6 participants
@notriddle @rustbot @rust-log-analyzer @GuillaumeGomez @bors @jyn514