Drop compiletest legacy directive check #131392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
A-testsuite
jieyouxu
added
the
T-compiler
This comment has been minimized.
This comment has been minimized.
jieyouxu
added
S-waiting-on-author
Zalathar
reviewed
Oct 8, 2024
| // specify them manually in every test file. (Some of the comments below have been copied over | ||
| // from the old `tests/run-make/coverage-reports/Makefile`, which no longer exists.) | ||
| // | ||
| // FIXME(jieyouxu): I feel like there's a better way to do this, leaving for later. |
There was a problem hiding this comment.
I think this is currently the least-awful way to achieve the desired effect, because there's no good way to hook into the ignore system. But with some appropriate refactoring there should definitely be a better approach.
There was a problem hiding this comment.
Yeah, just left a note for myself.
|
The test failure is genuine in that the test uses |
jieyouxu
commented
Oct 8, 2024
Sufficient time has passed (> 6 months) since we migrated from `//` to `//@`, so let's drop the legacy directive check as it causes friction due to false positives.
jieyouxu
force-pushed
the
remove-legacy-directive-check
branch
from
6fd3640 to
b81a3c8
Compare
|
Dropped the test changes and removal of early-return as they should be in follow-up PRs. This PR is intended to only remove the legacy directive check. |
rustbot
added
S-waiting-on-review
Urgau
approved these changes
Oct 8, 2024
|
LGTM. r=me after CI pass |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 8, 2024
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#131348 (More `rustc_infer` cleanups) - rust-lang#131392 (Drop compiletest legacy directive check) - rust-lang#131395 (Add a mailmap entry for bjorn3) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 8, 2024
Rollup merge of rust-lang#131392 - jieyouxu:remove-legacy-directive-check, r=Urgau Drop compiletest legacy directive check Sufficient time has passed (> 6 months) since we migrated from `//` to `//`@`,` so let's drop the legacy directive check as it causes friction due to false positives. As a side-effect, dropping the legacy directive check simplifies the directive scanning logic. The legacy directive check was originally added to help people be aware of the migration. Blocker for rust-lang#131382 cc `@ehuss.` Can be reviewed by any compiler/bootstrap reviewer.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 12, 2024
compiletest: Remove the one thing that was checking a directive's `original_line` This special handling of `ignore-tidy*` was introduced during the migration to `//`@`` directives (rust-lang#120881), and has become unnecessary after the subsequent removal of the legacy directive check (rust-lang#131392).
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 13, 2024
compiletest: Remove the one thing that was checking a directive's `original_line` This special handling of `ignore-tidy*` was introduced during the migration to `//`@`` directives (rust-lang#120881), and has become unnecessary after the subsequent removal of the legacy directive check (rust-lang#131392).
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 13, 2024
Rollup merge of rust-lang#131585 - Zalathar:original-line, r=jieyouxu compiletest: Remove the one thing that was checking a directive's `original_line` This special handling of `ignore-tidy*` was introduced during the migration to `//`@`` directives (rust-lang#120881), and has become unnecessary after the subsequent removal of the legacy directive check (rust-lang#131392).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sufficient time has passed (> 6 months) since we migrated from
//to//@, so let's drop thelegacy directive check as it causes friction due to false positives.
As a side-effect, dropping the legacy directive check simplifies the directive scanning logic.
The legacy directive check was originally added to help people be aware of the migration.
Blocker for #131382 cc @ehuss.
Can be reviewed by any compiler/bootstrap reviewer.