Skip to content

coverage: Remove code related to LLVM 17 #131543

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2024
Merged

coverage: Remove code related to LLVM 17 #131543

merged 1 commit into from
Oct 12, 2024

Conversation

Zalathar
Copy link
Contributor

In-tree LLVM is 19, and the minimum external LLVM was increased to 18 in #130487.

@Zalathar Zalathar added the A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage) label Oct 11, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 11, 2024

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 11, 2024
@petrochenkov
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 11, 2024

📌 Commit 9357277 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2024
@tgross35 tgross35 mentioned this pull request Oct 11, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 11, 2024
@bors
Auto merge of rust-lang#131573 - tgross35:rollup-r7l182a, r=tgross35
fb20e4d 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#130078 (rustdoc-json: change item ID's repr from a string to an int)
 - rust-lang#131065 (Port sort-research-rs test suite to Rust stdlib tests)
 - rust-lang#131109 (Stabilize `debug_more_non_exhaustive`)
 - rust-lang#131287 (stabilize const_result)
 - rust-lang#131463 (Stabilise `const_char_encode_utf8`.)
 - rust-lang#131543 (coverage: Remove code related to LLVM 17)
 - rust-lang#131552 (RustWrapper: adapt for rename of Intrinsic::getDeclaration)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2c385ba into rust-lang:master Oct 12, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Oct 12, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 12, 2024
@rust-timer
Unrolled build for rust-lang#131543
53afc3d 
Rollup merge of rust-lang#131543 - Zalathar:goodbye-llvm-17, r=petrochenkov

coverage: Remove code related to LLVM 17

In-tree LLVM is 19, and the minimum external LLVM was increased to 18 in rust-lang#130487.
@Zalathar Zalathar deleted the goodbye-llvm-17 branch October 12, 2024 02:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Swatinem Swatinem Swatinem approved these changes

Assignees

@petrochenkov petrochenkov

Labels
A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Zalathar @rustbot @petrochenkov @bors @Swatinem