Skip to content

LLVMConstInt only allows integer types #131605

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Conversation

dianqk
Copy link
Member

@dianqk dianqk commented Oct 12, 2024

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 12, 2024
@rust-log-analyzer

This comment has been minimized.

@the8472
Copy link
Member

the8472 commented Oct 12, 2024

Thanks.

Context: I'm hitting LLVM asserts while experimenting, this change should make it easier to diagnose.

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 12, 2024

📌 Commit 1efffe7 has been approved by the8472

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 12, 2024
Rollup of 7 pull requests

Successful merges:

 - rust-lang#130870 (Add suggestion for removing invalid path sep `::` in fn def)
 - rust-lang#130954 (Stabilize const `ptr::write*` and `mem::replace`)
 - rust-lang#131233 (std: fix stdout-before-main)
 - rust-lang#131590 (yeet some clones)
 - rust-lang#131596 (mark InterpResult as must_use)
 - rust-lang#131597 (Take a display name for `tool_check_step!`)
 - rust-lang#131605 (`LLVMConstInt` only allows integer types)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1b98ae0 into rust-lang:master Oct 12, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 12, 2024
Rollup merge of rust-lang#131605 - DianQK:llvm-const-int, r=the8472

`LLVMConstInt` only allows integer types

See https://github.com/llvm/llvm-project/blob/llvmorg-19.1.1/llvm/lib/IR/Core.cpp#L1535-L1546.

r? the8472
@rustbot rustbot added this to the 1.83.0 milestone Oct 12, 2024
@dianqk dianqk deleted the llvm-const-int branch October 12, 2024 22:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants