Remove const trait bound modifier hack #131653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Although it still seems weird that we're pushing constness for traits in @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 13, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#130356 (don't warn about a missing change-id in CI) - rust-lang#130900 (Do not output () on empty description) - rust-lang#131066 (Add the Chinese translation entry to the RustByExample build process) - rust-lang#131067 (Fix std_detect links) - rust-lang#131644 (Clean up some Miri things in `sys/windows`) - rust-lang#131646 (sys/unix: add comments for some Miri fallbacks) - rust-lang#131653 (Remove const trait bound modifier hack) - rust-lang#131659 (enable `download_ci_llvm` test) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 13, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#130356 (don't warn about a missing change-id in CI) - rust-lang#130900 (Do not output () on empty description) - rust-lang#131066 (Add the Chinese translation entry to the RustByExample build process) - rust-lang#131067 (Fix std_detect links) - rust-lang#131644 (Clean up some Miri things in `sys/windows`) - rust-lang#131646 (sys/unix: add comments for some Miri fallbacks) - rust-lang#131653 (Remove const trait bound modifier hack) - rust-lang#131659 (enable `download_ci_llvm` test) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 14, 2024
Rollup merge of rust-lang#131653 - compiler-errors:no-modifier-hack, r=fee1-dead Remove const trait bound modifier hack It's no longer necessary, according to the test suite :D r? `@fee1-dead` or anyone really
Well the test that used to exercise this hack I added in #119540 was effectively 'disabled' by removing the |
|
Ideally the hack would be implemented some other way since I'm cleaning up how we pass through trait bound modifiers in #131652. |
|
No longer seems to be necessary: |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's no longer necessary, according to the test suite :D
r? @fee1-dead or anyone really