Skip to content

Remove const trait bound modifier hack #131653

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

compiler-errors
Copy link
Member

It's no longer necessary, according to the test suite :D

r? @fee1-dead or anyone really

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 13, 2024
@fee1-dead
Copy link
Member

Although it still seems weird that we're pushing constness for traits in lower_path_segment somehow. Might need more investigation, though I'm a bit busy these few weeks.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 13, 2024

📌 Commit 204e6af has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 13, 2024
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#130356 (don't warn about a missing change-id in CI)
 - rust-lang#130900 (Do not output () on empty description)
 - rust-lang#131066 (Add the Chinese translation entry to the RustByExample build process)
 - rust-lang#131067 (Fix std_detect links)
 - rust-lang#131644 (Clean up some Miri things in `sys/windows`)
 - rust-lang#131646 (sys/unix: add comments for some Miri fallbacks)
 - rust-lang#131653 (Remove const trait bound modifier hack)
 - rust-lang#131659 (enable `download_ci_llvm` test)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 13, 2024
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#130356 (don't warn about a missing change-id in CI)
 - rust-lang#130900 (Do not output () on empty description)
 - rust-lang#131066 (Add the Chinese translation entry to the RustByExample build process)
 - rust-lang#131067 (Fix std_detect links)
 - rust-lang#131644 (Clean up some Miri things in `sys/windows`)
 - rust-lang#131646 (sys/unix: add comments for some Miri fallbacks)
 - rust-lang#131653 (Remove const trait bound modifier hack)
 - rust-lang#131659 (enable `download_ci_llvm` test)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 20add51 into rust-lang:master Oct 14, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Oct 14, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 14, 2024
Rollup merge of rust-lang#131653 - compiler-errors:no-modifier-hack, r=fee1-dead

Remove const trait bound modifier hack

It's no longer necessary, according to the test suite :D

r? `@fee1-dead` or anyone really
@fmease
Copy link
Member

fmease commented Oct 14, 2024

according to the test suite

Well the test that used to exercise this hack I added in #119540 was effectively 'disabled' by removing the effects feature flag: tests/ui/rfcs/rfc-2632-const-trait-impl/const-trait-bounds-trait-objects.rs. Though I haven't checked if that hack is still needed.

@compiler-errors
Copy link
Member Author

Ideally the hack would be implemented some other way since I'm cleaning up how we pass through trait bound modifiers in #131652.

@cuviper cuviper modified the milestones: 1.83.0, 1.84.0 Oct 14, 2024
@fmease
Copy link
Member

fmease commented Oct 15, 2024

No longer seems to be necessary: rustc +9322d183f45e0fd5a509820874cc5ff27744a479 tests/ui/rfcs/rfc-2632-const-trait-impl/const-trait-bounds-trait-objects.rs --edition=2021 -Zcrate-attr='feature(effects)' -Znext-solver doesn't ICE. So good riddance!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants