Hir attributes #131808

jdonszelmann · 2024-10-17T00:40:11Z

This PR needs some explanation, it's somewhat large.

This is step one as described in Attribute handling reworks compiler-team#796. I've added a new hir::Attribute which is a lowered version of ast::Attribute. Right now, this has few concrete effects, however every place that after this PR parses a hir::Attribute should later get a pre-parsed attribute as described in Attribute handling reworks compiler-team#796 and transitively Tracking issue: Attribute refactor #131229.
an extension trait AttributeExt is added, which is implemented for both ast::Attribute and hir::Atribute. This makes hir::Attributes mostly compatible with code that used to parse ast::Attribute. All its methods are also added as inherent methods to avoid having to import the trait everywhere in the compiler.
- Incremental can not not hash ast::Attribute at all.

compiler/rustc_ast/src/ast.rs

compiler/rustc_hir/src/hir.rs

xFrednet

The Clippy changes look good to me :D

=^.^=

src/tools/rustfmt/src/attr.rs

jdonszelmann · 2024-12-15T19:30:24Z

@bors r=oli-obk,petrochenkov

bors · 2024-12-15T19:30:27Z

📌 Commit 1d5ec2c has been approved by oli-obk,petrochenkov

It is now in the queue for this repository.

…bk,petrochenkov Hir attributes This PR needs some explanation, it's somewhat large. - This is step one as described in rust-lang/compiler-team#796. I've added a new `hir::Attribute` which is a lowered version of `ast::Attribute`. Right now, this has few concrete effects, however every place that after this PR parses a `hir::Attribute` should later get a pre-parsed attribute as described in rust-lang/compiler-team#796 and transitively rust-lang#131229. - an extension trait `AttributeExt` is added, which is implemented for both `ast::Attribute` and `hir::Atribute`. This makes `hir::Attributes` mostly compatible with code that used to parse `ast::Attribute`. All its methods are also added as inherent methods to avoid having to import the trait everywhere in the compiler. - Incremental can not not hash `ast::Attribute` at all.

bors · 2024-12-15T22:01:41Z

⌛ Testing commit 1d5ec2c with merge 6add46f...

bors · 2024-12-15T22:05:37Z

⌛ Testing commit 1d5ec2c with merge f2b91cc...

bors · 2024-12-16T00:54:15Z

☀️ Test successful - checks-actions
Approved by: oli-obk,petrochenkov
Pushing f2b91cc to master...

rust-timer · 2024-12-16T02:12:12Z

Finished benchmarking commit (f2b91cc): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.2%, 1.1%]	9
Regressions ❌ (secondary)	0.4%	[0.1%, 0.6%]	20
Improvements ✅ (primary)	-0.2%	[-0.4%, -0.2%]	3
Improvements ✅ (secondary)	-0.3%	[-0.7%, -0.2%]	5
All ❌✅ (primary)	0.3%	[-0.4%, 1.1%]	12

Max RSS (memory usage)

Results (primary -0.9%, secondary -0.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[0.7%, 1.6%]	2
Regressions ❌ (secondary)	2.6%	[1.8%, 3.3%]	2
Improvements ✅ (primary)	-1.1%	[-2.4%, -0.5%]	20
Improvements ✅ (secondary)	-2.1%	[-3.0%, -1.6%]	6
All ❌✅ (primary)	-0.9%	[-2.4%, 1.6%]	22

Cycles

Results (primary 1.4%, secondary 1.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.4%	[0.6%, 2.8%]	23
Regressions ❌ (secondary)	1.9%	[1.1%, 2.3%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.4%	[0.6%, 2.8%]	23

Binary size

Results (primary -0.2%, secondary -0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.2%	[-1.0%, -0.0%]	75
Improvements ✅ (secondary)	-0.4%	[-1.0%, -0.0%]	21
All ❌✅ (primary)	-0.2%	[-1.0%, -0.0%]	75

Bootstrap: 770.348s -> 773.825s (0.45%)
Artifact size: 333.25 MiB -> 332.94 MiB (-0.09%)

jieyouxu · 2024-12-16T05:04:17Z

(Perf regression is real as we are doing more work, not sure how to claw perf back personally.)

oli-obk · 2024-12-16T06:08:27Z

Interestingly it's only a rustdoc regression. Maybe run cachegrind on one of them and see if it's sth obvious?

jdonszelmann · 2024-12-16T06:48:08Z

Zzzzz good morning, oh that's interesting, didn't expect that. I'll take a look today

Try to fix perf regression in rustdoc after hir attributes Slight performance regression introduced in rust-lang#131808 r? `@jieyouxu`

jieyouxu · 2024-12-16T22:43:26Z

For wg-perf: #134376 seems to address the regression.

…youxu Try to fix perf regression in rustdoc after hir attributes Slight performance regression introduced in rust-lang#131808 r? `@jieyouxu`

Kobzol · 2024-12-23T14:11:20Z

The regression was fixed in #134376.

@rustbot label: +perf-regression-triaged

Relevant upstream PR: rust-lang/rust#131808. This required replacing `rustc_ast::Attribute` with the new `rustc_hir::Attribute`. Resolves #3788 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

This comment was marked as resolved.

# to view

rustbot assigned fee1-dead Oct 17, 2024

This comment was marked as outdated.

# to view

jdonszelmann mentioned this pull request Oct 16, 2024

Attribute handling reworks rust-lang/compiler-team#796

Closed

7 tasks

This comment has been minimized.

# to view

jieyouxu reviewed Oct 17, 2024

View reviewed changes

compiler/rustc_ast/src/ast.rs Outdated Show resolved Hide resolved

compiler/rustc_ast/src/ast.rs Outdated Show resolved Hide resolved

compiler/rustc_ast/src/ast.rs Show resolved Hide resolved

compiler/rustc_hir/src/hir.rs Outdated Show resolved Hide resolved

jdonszelmann force-pushed the hir-attributes branch from cc2499a to 6e0f96e Compare October 17, 2024 05:56

rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-release Relevant to the release subteam, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Oct 17, 2024

jdonszelmann force-pushed the hir-attributes branch 4 times, most recently from cf3179b to e3133bb Compare October 17, 2024 06:52

petrochenkov self-assigned this Oct 17, 2024

This comment has been minimized.

# to view

xFrednet approved these changes Oct 17, 2024

View reviewed changes

jdonszelmann marked this pull request as ready for review October 17, 2024 18:44

This comment was marked as resolved.

# to view

ytmimi reviewed Oct 17, 2024

View reviewed changes

src/tools/rustfmt/src/attr.rs Outdated Show resolved Hide resolved

jdonszelmann force-pushed the hir-attributes branch 2 times, most recently from 1920abd to cefa0ea Compare October 17, 2024 22:02

cjgillot self-assigned this Oct 17, 2024

This comment was marked as resolved.

# to view

jieyouxu removed T-release Relevant to the release subteam, which will review and decide on the PR/issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 15, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2024

jieyouxu mentioned this pull request Dec 15, 2024

Clippy subtree update #134343

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 16, 2024

bors merged commit f2b91cc into rust-lang:master Dec 16, 2024
7 checks passed

rustbot added this to the 1.85.0 milestone Dec 16, 2024

bors mentioned this pull request Dec 16, 2024

Lint against manual impl Default that could have been derived #134175

Closed

rustbot added the perf-regression Performance regression. label Dec 16, 2024

jdonszelmann mentioned this pull request Dec 16, 2024

Try to fix perf regression in rustdoc after hir attributes #134376

Merged

jdonszelmann deleted the hir-attributes branch December 16, 2024 12:18

rustbot added the perf-regression-triaged The performance regression has been triaged. label Dec 23, 2024

zhassan-aws mentioned this pull request Dec 26, 2024

Upgrade toolchain to nightly-2024-12-18 model-checking/kani#3794

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hir attributes #131808

Hir attributes #131808

jdonszelmann commented Oct 17, 2024 •

edited by oli-obk

Loading

This comment was marked as resolved.

This comment was marked as outdated.

This comment has been minimized.

This comment has been minimized.

xFrednet left a comment

This comment was marked as resolved.

This comment was marked as resolved.

jdonszelmann commented Dec 15, 2024

bors commented Dec 15, 2024

bors commented Dec 15, 2024

bors commented Dec 15, 2024

bors commented Dec 16, 2024

rust-timer commented Dec 16, 2024

jieyouxu commented Dec 16, 2024

oli-obk commented Dec 16, 2024

jdonszelmann commented Dec 16, 2024

jieyouxu commented Dec 16, 2024

Kobzol commented Dec 23, 2024

Hir attributes #131808

Hir attributes #131808

Conversation

jdonszelmann commented Oct 17, 2024 • edited by oli-obk Loading

This comment was marked as resolved.

This comment was marked as outdated.

This comment has been minimized.

This comment has been minimized.

xFrednet left a comment

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as resolved.

jdonszelmann commented Dec 15, 2024

bors commented Dec 15, 2024

bors commented Dec 15, 2024

bors commented Dec 15, 2024

bors commented Dec 16, 2024

rust-timer commented Dec 16, 2024

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

jieyouxu commented Dec 16, 2024

oli-obk commented Dec 16, 2024

jdonszelmann commented Dec 16, 2024

jieyouxu commented Dec 16, 2024

Kobzol commented Dec 23, 2024

jdonszelmann commented Oct 17, 2024 •

edited by oli-obk

Loading