Skip to content

Add WASM | WASI | Emscripten groups to triagebot.toml #131875

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2024
Merged

Add WASM | WASI | Emscripten groups to triagebot.toml #131875

merged 1 commit into from
Oct 26, 2024

Conversation

juntyr
Copy link
Contributor

@juntyr juntyr commented Oct 18, 2024 •
edited
Loading

Tracking issue: rust-lang/compiler-team#799

This is blocked on amending the notification group section so that the instructions links point somewhere: rust-lang/rustc-dev-guide#2100

@rustbot
Copy link
Collaborator

rustbot commented Oct 18, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2024
@juntyr juntyr mentioned this pull request Oct 18, 2024
Closed
8 tasks
@workingjubilee workingjubilee added O-emscripten Target: 50% off wasm32-unknown-musl. the savings come out of stdio.h, but hey, you get SDL! O-wasm Target: WASM (WebAssembly), http://webassembly.org/ O-wasi Operating system: Wasi, Webassembly System Interface labels Oct 21, 2024
@juntyr juntyr marked this pull request as ready for review October 21, 2024 04:11
@rustbot
Copy link
Collaborator

rustbot commented Oct 21, 2024

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@juntyr
Copy link
Contributor Author

juntyr commented Oct 21, 2024

@rustbot ready

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 26, 2024

📌 Commit a4ffeb0 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 26, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 26, 2024
@bors
Auto merge of rust-lang#132190 - matthiaskrgr:rollup-rsocfiz, r=matth…
9b18a12 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#131875 (Add WASM | WASI | Emscripten groups to triagebot.toml)
 - rust-lang#132019 (Document `PartialEq` impl for `OnceLock`)
 - rust-lang#132182 (Downgrade `untranslatable_diagnostic` and `diagnostic_outside_of_impl` to `allow`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 13ec1b0 into rust-lang:master Oct 26, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 26, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 26, 2024
@rust-timer
Unrolled build for rust-lang#131875
68679bf 
Rollup merge of rust-lang#131875 - juntyr:wasm-notification-groups-triage, r=Mark-Simulacrum

Add WASM | WASI | Emscripten groups to triagebot.toml

Tracking issue: rust-lang/compiler-team#799

~~This is blocked on amending the notification group section so that the instructions links point somewhere: rust-lang/rustc-dev-guide#2100
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself O-emscripten Target: 50% off wasm32-unknown-musl. the savings come out of stdio.h, but hey, you get SDL! O-wasi Operating system: Wasi, Webassembly System Interface O-wasm Target: WASM (WebAssembly), http://webassembly.org/ S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
5 participants
@juntyr @rustbot @Mark-Simulacrum @bors @workingjubilee