Skip to content

checktools.sh: add link to issue for more context about disabled Miri tests #131877

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

RalfJung
Copy link
Member

Adds some context for the changes made in #130072.

@rustbot
Copy link
Collaborator

rustbot commented Oct 18, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Oct 18, 2024
@jieyouxu
Copy link
Member

Thanks
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 18, 2024

📌 Commit b096f90 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2024
jhpratt added a commit to jhpratt/rust that referenced this pull request Oct 18, 2024
…youxu

checktools.sh: add link to issue for more context about disabled Miri tests

Adds some context for the changes made in rust-lang#130072.
@RalfJung
Copy link
Member Author

@bors r-

Turns out there's more to say here, #130072 is more confusing than I thought.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 18, 2024
@RalfJung
Copy link
Member Author

Okay now it should be right.

r? @ChrisDenton

@ChrisDenton
Copy link
Member

This seems right to me.

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 18, 2024

📌 Commit 4277160 has been approved by ChrisDenton

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 18, 2024
jhpratt added a commit to jhpratt/rust that referenced this pull request Oct 18, 2024
…isDenton

checktools.sh: add link to issue for more context about disabled Miri tests

Adds some context for the changes made in rust-lang#130072.
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 18, 2024
Rollup of 9 pull requests

Successful merges:

 - rust-lang#130136 (Partially stabilize const_pin)
 - rust-lang#131755 (Regression test for AVR `rjmp` offset)
 - rust-lang#131774 (Add getentropy for RTEMS)
 - rust-lang#131802 (Dont ICE when computing coverage of synthetic async closure body)
 - rust-lang#131809 (Fix predicate signatures in retain_mut docs)
 - rust-lang#131858 (Remove outdated documentation for `repeat_n`)
 - rust-lang#131866 (Avoid use imports in `thread_local_inner!`)
 - rust-lang#131874 (Default to the medium code model on OpenHarmony LoongArch target)
 - rust-lang#131877 (checktools.sh: add link to issue for more context about disabled Miri tests)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 80a8f7b into rust-lang:master Oct 18, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 18, 2024
Rollup merge of rust-lang#131877 - RalfJung:checktools-comment, r=ChrisDenton

checktools.sh: add link to issue for more context about disabled Miri tests

Adds some context for the changes made in rust-lang#130072.
@rustbot rustbot added this to the 1.84.0 milestone Oct 18, 2024
@RalfJung RalfJung deleted the checktools-comment branch October 19, 2024 06:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants