Represent hir::TraitBoundModifiers as distinct parts in HIR

[compiler-errors]

Stop squashing distinct polarity and constness into a single hir::TraitBoundModifier.

This PR doesn't attempt to handle all the corner cases correctly, since the old code certainly did not either; but it should be much easier for, e.g., rustc devs working on diagnostics, or clippy devs, to actually handle constness and polarity correctly.

try-job: x86_64-gnu-stable

[rustbot]

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

HIR ty lowering was modified

cc @fmease

[compiler-errors]

Should probably be reviewed by someone on the compiler side, though feedback is obviously useful for the rustdoc and clippy sides.

r? compiler

[bors]

☔ The latest upstream changes (presumably #131988) made this pull request unmergeable. Please resolve the merge conflicts.

[fmease]

This is basically #119163 but now for HIR, so +1 from me.

r=me after rebase and nitpicks addressed

[fmease]

@bors r+

[bors]

📌 Commit b6e4fca has been approved by fmease

It is now in the queue for this repository.

[workingjubilee]

Suspecting this based on #132018 (comment)

@bors r-

[workingjubilee]

@bors try

[bors]

⌛ Trying commit b6e4fca with merge aa43197...

[fmease]

It's 100% this PR: The HIR stats for GenericBound have changed, need to be updated.

[bors]

💔 Test failed - checks-actions

[rustbot]

Changes to the size of AST and/or HIR nodes.

cc @nnethercote

[fmease]

While we're at it, let's maybe perf test the old try build (because GenericBound grew in size) (edit: not old, failing; I goofed)? idk, I should've done so yesterday already

[@] rust-timer build aa43197

[fmease]

Seems like rust-timer doesn't like old try builds (edit: not old, failing; I goofed).

Alrighty then, @bors r+ rollup=iffy

[bors]

📌 Commit febb3f7 has been approved by fmease

It is now in the queue for this repository.

[bors]

⌛ Testing commit febb3f7 with merge e1f3068...

[bors]

☀️ Test successful - checks-actions
Approved by: fmease
Pushing e1f3068 to master...

[rust-timer]

Finished benchmarking commit (e1f3068): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.1%, 0.1%]	1

Max RSS (memory usage)

Results (primary -0.4%, secondary -0.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.0%	[1.0%, 1.0%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.9%	[-2.9%, -0.8%]	2
Improvements ✅ (secondary)	-0.7%	[-0.7%, -0.7%]	1
All ❌✅ (primary)	-0.4%	[-2.9%, 1.0%]	4

Cycles

Results (secondary -3.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.8%	[-3.8%, -3.8%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 780.01s -> 781.732s (0.22%)
Artifact size: 333.69 MiB -> 333.67 MiB (-0.01%)

[rust-timer]

Queued aa43197 with parent 814df6e, future comparison URL.
There is currently 1 preceding artifact in the queue.
It will probably take at least ~1.8 hours until the benchmark run finishes.