Stop being so bail-y in candidate assembly #132090

compiler-errors · 2024-10-24T01:47:11Z

A conceptual follow-up to #132084. We gotta stop bailing so much when there are errors; it's both unnecessary, leads to weird knock-on errors, and it's messing up the vibes lol

compiler-errors · 2024-10-24T01:47:52Z

Whoops, I wanted an lcnr vibe check

r? lcnr

compiler-errors · 2024-10-24T01:48:33Z

compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs

-                // may also be useful for predicates other than `Sized`
-                // Error type cannot possibly implement `Sized` (fixes #123154)
-                if let Err(e) = obligation.predicate.skip_binder().self_ty().error_reported() {
-                    return Err(SelectionError::Overflow(e.into()));


:((((((((((( what the heck were we doing here!!

lcnr · 2024-10-24T08:23:16Z

tests/ui/traits/object/dyn-no-impl-subst.rs

@@ -0,0 +1,16 @@
+#![feature(dyn_compatible_for_dispatch)]
+


regression test for X

compiler-errors · 2024-10-24T19:37:16Z

:think: i guess it's failing on --target=i686-unknown-linux-gnu.

bors · 2024-10-29T23:09:34Z

☔ The latest upstream changes (presumably #132326) made this pull request unmergeable. Please resolve the merge conflicts.

compiler-errors · 2024-11-21T01:35:45Z

@rustbot ready

lcnr · 2024-11-21T12:49:07Z

@bors r+ rollup

bors · 2024-11-21T12:49:10Z

📌 Commit 0465f71 has been approved by lcnr

It is now in the queue for this repository.

Stop being so bail-y in candidate assembly A conceptual follow-up to rust-lang#132084. We gotta stop bailing so much when there are errors; it's both unnecessary, leads to weird knock-on errors, and it's messing up the vibes lol

…mpiler-errors Rollup of 9 pull requests Successful merges: - rust-lang#129238 (Stabilize `Ipv6Addr::is_unique_local` and `Ipv6Addr::is_unicast_link_local`) - rust-lang#130867 (distinguish overflow and unimplemented in Step::steps_between) - rust-lang#131505 (use `confstr(_CS_DARWIN_USER_TEMP_DIR, ...)` as a `TMPDIR` fallback on Darwin) - rust-lang#132090 (Stop being so bail-y in candidate assembly) - rust-lang#133159 (Don't allow `-Zunstable-options` to take a value ) - rust-lang#133215 (Fix missing submodule in `./x vendor`) - rust-lang#133286 (Re-delay a resolve `bug` related to `Self`-ctor in patterns) - rust-lang#133301 (Add code example for `wrapping_neg` method for signed integers) - rust-lang#133313 (Use arc4random of libc for RTEMS target) r? `@ghost` `@rustbot` modify labels: rollup

Stop being so bail-y in candidate assembly A conceptual follow-up to rust-lang#132084. We gotta stop bailing so much when there are errors; it's both unnecessary, leads to weird knock-on errors, and it's messing up the vibes lol

Rollup of 13 pull requests Successful merges: - rust-lang#130867 (distinguish overflow and unimplemented in Step::steps_between) - rust-lang#131859 (Update TRPL to add new Chapter 17: Async and Await) - rust-lang#132090 (Stop being so bail-y in candidate assembly) - rust-lang#132658 (Detect const in pattern with typo) - rust-lang#133041 (Print name of env var in `--print=deployment-target`) - rust-lang#133102 (aarch64 softfloat target: always pass floats in int registers) - rust-lang#133159 (Don't allow `-Zunstable-options` to take a value ) - rust-lang#133217 ([AIX] Add option -X32_64 to the "strip" command) - rust-lang#133237 (Minimally constify `Add`) - rust-lang#133238 (re-export `is_loongarch_feature_detected`) - rust-lang#133286 (Re-delay a resolve `bug` related to `Self`-ctor in patterns) - rust-lang#133301 (Add code example for `wrapping_neg` method for signed integers) - rust-lang#133313 (Use arc4random of libc for RTEMS target) Failed merges: - rust-lang#133215 (Fix missing submodule in `./x vendor`) r? `@ghost` `@rustbot` modify labels: rollup

Stop being so bail-y in candidate assembly A conceptual follow-up to rust-lang#132084. We gotta stop bailing so much when there are errors; it's both unnecessary, leads to weird knock-on errors, and it's messing up the vibes lol

…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#131505 (use `confstr(_CS_DARWIN_USER_TEMP_DIR, ...)` as a `TMPDIR` fallback on Darwin) - rust-lang#131859 (Update TRPL to add new Chapter 17: Async and Await) - rust-lang#132090 (Stop being so bail-y in candidate assembly) - rust-lang#132597 (btree: don't leak value if destructor of key panics) - rust-lang#132911 (Pretty print async fn sugar in opaques and trait bounds) - rust-lang#133159 (Don't allow `-Zunstable-options` to take a value ) - rust-lang#133247 (Reduce integer `Display` implementation size) - rust-lang#133286 (Re-delay a resolve `bug` related to `Self`-ctor in patterns) Failed merges: - rust-lang#133215 (Fix missing submodule in `./x vendor`) r? `@ghost` `@rustbot` modify labels: rollup

…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#132090 (Stop being so bail-y in candidate assembly) - rust-lang#132658 (Detect const in pattern with typo) - rust-lang#132911 (Pretty print async fn sugar in opaques and trait bounds) - rust-lang#133102 (aarch64 softfloat target: always pass floats in int registers) - rust-lang#133159 (Don't allow `-Zunstable-options` to take a value ) - rust-lang#133208 (generate-copyright: Now generates a library file too.) - rust-lang#133215 (Fix missing submodule in `./x vendor`) - rust-lang#133264 (implement OsString::truncate) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#132090 - compiler-errors:baily, r=lcnr Stop being so bail-y in candidate assembly A conceptual follow-up to rust-lang#132084. We gotta stop bailing so much when there are errors; it's both unnecessary, leads to weird knock-on errors, and it's messing up the vibes lol

fmease · 2025-05-22T09:44:11Z

@compiler-errors I assume you simply forgot but in the future could you please make sure to always add "Fixes #NNN" for all fixed crash tests? In this case, #125758, #127351, #127353 (closed manually by oli) and #127742. That's like literally the point of crash tests ^^' Sorry to be nagging like that. Ok thx, byee～

rustbot assigned jieyouxu Oct 24, 2024

This comment was marked as outdated.

# to view

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 24, 2024

rustbot assigned lcnr and unassigned jieyouxu Oct 24, 2024

compiler-errors commented Oct 24, 2024

View reviewed changes

This comment has been minimized.

# to view

lcnr reviewed Oct 24, 2024

View reviewed changes

compiler-errors force-pushed the baily branch from be0b97f to 6b46613 Compare October 24, 2024 18:21

This comment has been minimized.

# to view

Stop being so bail-y in candidate assembly

0465f71

compiler-errors force-pushed the baily branch from 6b46613 to 0465f71 Compare November 21, 2024 01:35

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2024

GuillaumeGomez mentioned this pull request Nov 21, 2024

Rollup of 8 pull requests #133296

Closed

compiler-errors mentioned this pull request Nov 22, 2024

Rollup of 9 pull requests #133322

Closed

jhpratt mentioned this pull request Nov 22, 2024

Rollup of 13 pull requests #133329

Closed

jieyouxu mentioned this pull request Nov 22, 2024

Rollup of 10 pull requests #133340

Closed

compiler-errors mentioned this pull request Nov 22, 2024

Rollup of 8 pull requests #133350

Closed

compiler-errors mentioned this pull request Nov 23, 2024

Rollup of 8 pull requests #133360

Merged

bors merged commit 5a0086f into rust-lang:master Nov 23, 2024
6 checks passed

rustbot added this to the 1.85.0 milestone Nov 23, 2024

matthiaskrgr mentioned this pull request Feb 28, 2025

ICE: did not expect inference variables here (wfck) #137813

Closed

apiraino mentioned this pull request Apr 1, 2025

Compiler hangs during execution #139197

Open

This was referenced May 3, 2025

ICE: Failed to normalize Alias(Weak, AliasTy { with feature(lazy_type_alias) #127351

Closed

ICE: Failed to normalize Alias(Weak, AliasTy { with feature(type_alias_impl_trait) #127353

Closed

This was referenced May 22, 2025

ICE: SizeSkeleton::compute layout errored in layout.rs #125758

Closed

ICE: expected wide pointer extra data (e.g. slice length or trait object vtable) #127742

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Stop being so bail-y in candidate assembly #132090

Stop being so bail-y in candidate assembly #132090

Uh oh!

compiler-errors commented Oct 24, 2024

Uh oh!

This comment was marked as outdated.

compiler-errors commented Oct 24, 2024

Uh oh!

compiler-errors Oct 24, 2024

Uh oh!

This comment has been minimized.

lcnr Oct 24, 2024

Uh oh!

This comment has been minimized.

compiler-errors commented Oct 24, 2024

Uh oh!

bors commented Oct 29, 2024

Uh oh!

compiler-errors commented Nov 21, 2024

Uh oh!

lcnr commented Nov 21, 2024

Uh oh!

bors commented Nov 21, 2024

Uh oh!

Uh oh!

fmease commented May 22, 2025 •

edited

Loading

Uh oh!

Uh oh!

Stop being so bail-y in candidate assembly #132090

Stop being so bail-y in candidate assembly #132090

Uh oh!

Conversation

compiler-errors commented Oct 24, 2024

Uh oh!

This comment was marked as outdated.

compiler-errors commented Oct 24, 2024

Uh oh!

compiler-errors Oct 24, 2024

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

lcnr Oct 24, 2024

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

compiler-errors commented Oct 24, 2024

Uh oh!

bors commented Oct 29, 2024

Uh oh!

compiler-errors commented Nov 21, 2024

Uh oh!

lcnr commented Nov 21, 2024

Uh oh!

bors commented Nov 21, 2024

Uh oh!

Uh oh!

fmease commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

fmease commented May 22, 2025 •

edited

Loading