Skip to content

remove change-id from CI script #132130

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2024
Merged

remove change-id from CI script #132130

merged 1 commit into from
Oct 25, 2024

Conversation

onur-ozkan
Copy link
Member

It's not necessary to set change-id for CI since #130356.

@onur-ozkan
remove change-id from CI script
03d23a7 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@rustbot
Copy link
Collaborator

rustbot commented Oct 25, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Oct 25, 2024
@Kobzol
Copy link
Contributor

Kobzol commented Oct 25, 2024

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 25, 2024

📌 Commit 03d23a7 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 25, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 25, 2024
@bors
Auto merge of rust-lang#132148 - matthiaskrgr:rollup-c155tcy, r=matth…
c1db4dc 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#132106 (Pass Ident by reference in ast Visitor)
 - rust-lang#132130 (remove `change-id` from CI script)
 - rust-lang#132137 (library: consistently use American spelling for 'behavior')

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f8cae25 into rust-lang:master Oct 25, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 25, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 25, 2024
@rust-timer
Unrolled build for rust-lang#132130
34de88f 
Rollup merge of rust-lang#132130 - onur-ozkan:remove-ci-change-id, r=Kobzol

remove `change-id` from CI script

It's not necessary to set `change-id` for CI since rust-lang#130356.
@onur-ozkan onur-ozkan deleted the remove-ci-change-id branch October 26, 2024 18:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
5 participants
@onur-ozkan @rustbot @Kobzol @bors @Mark-Simulacrum