Skip to content

Revert #127731 "Emit error when calling/declaring functions with unavailable …" #132152

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

lqd
Copy link
Member

@lqd lqd commented Oct 25, 2024

This reverts #127731 due to the unexpected perf regressions and to give time to mitigate the regressions before re-landing it.

r? @RalfJung cc @veluca93

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 25, 2024
@compiler-errors
Copy link
Member

wow what a regression 😨

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Oct 25, 2024

📌 Commit bd8477b has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2024
@bors
Copy link
Collaborator

bors commented Oct 26, 2024

⌛ Testing commit bd8477b with merge ae4c6b6...

@bors
Copy link
Collaborator

bors commented Oct 26, 2024

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing ae4c6b6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 26, 2024
@bors bors merged commit ae4c6b6 into rust-lang:master Oct 26, 2024
7 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 26, 2024
@lqd lqd deleted the revert-127731 branch October 26, 2024 07:46
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ae4c6b6): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.3% [0.3%, 0.3%] 1
Improvements ✅
(primary)
-4.7% [-14.4%, -0.3%] 75
Improvements ✅
(secondary)
-4.5% [-22.7%, -0.2%] 27
All ❌✅ (primary) -4.7% [-14.4%, -0.3%] 75

Max RSS (memory usage)

Results (primary -4.1%, secondary -2.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.0% [2.8%, 3.3%] 2
Improvements ✅
(primary)
-4.1% [-10.3%, -1.0%] 65
Improvements ✅
(secondary)
-3.1% [-5.3%, -0.9%] 22
All ❌✅ (primary) -4.1% [-10.3%, -1.0%] 65

Cycles

Results (primary -9.6%, secondary -8.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.6% [2.3%, 2.8%] 2
Regressions ❌
(secondary)
4.0% [3.4%, 5.2%] 3
Improvements ✅
(primary)
-10.0% [-20.6%, -1.6%] 53
Improvements ✅
(secondary)
-12.6% [-27.7%, -0.9%] 10
All ❌✅ (primary) -9.6% [-20.6%, 2.8%] 55

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 787.606s -> 785.03s (-0.33%)
Artifact size: 333.58 MiB -> 333.74 MiB (0.05%)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants