Skip to content

docs: Correctly link riscv32e from platform-support.md #132205

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

workingjubilee
Copy link
Member

Correctly link the riscv32e platform support page.

Just a mistake during the iteration of #130555 that was missed in review. Presumably the rv32e-none and rv32i-none pages eventually should get merged, but this is a relatively recent addition to the ISA definition so it is not clear the current RISCV Embedded group has the expertise on-hand... nor did it have their consent.

@rustbot
Copy link
Collaborator

rustbot commented Oct 26, 2024

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 26, 2024
@tgross35
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 26, 2024

📌 Commit 2ebb8ec has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2024
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Oct 27, 2024
…-mislinked, r=tgross35

docs: Correctly link riscv32e from platform-support.md

Correctly link the riscv32e platform support page.

Just a mistake during the iteration of rust-lang#130555 that was missed in review. Presumably the rv32e-none and rv32i-none pages eventually should get merged, but this is a relatively recent addition to the ISA definition so it is not clear the current RISCV Embedded group has the expertise on-hand... nor did it have their consent.
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 27, 2024
…kingjubilee

Rollup of 5 pull requests

Successful merges:

 - rust-lang#132123 (allow type-based search on foreign functions)
 - rust-lang#132170 (Add a Few Codegen Tests)
 - rust-lang#132183 (Fix code HTML items making big blocks if too long)
 - rust-lang#132192 (expand: Stop using artificial `ast::Item` for macros loaded from metadata)
 - rust-lang#132205 (docs: Correctly link riscv32e from platform-support.md)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 27, 2024
…kingjubilee

Rollup of 4 pull requests

Successful merges:

 - rust-lang#132123 (allow type-based search on foreign functions)
 - rust-lang#132183 (Fix code HTML items making big blocks if too long)
 - rust-lang#132192 (expand: Stop using artificial `ast::Item` for macros loaded from metadata)
 - rust-lang#132205 (docs: Correctly link riscv32e from platform-support.md)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b61d3f6 into rust-lang:master Oct 27, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 27, 2024
Rollup merge of rust-lang#132205 - workingjubilee:rv32e-platform-docs-mislinked, r=tgross35

docs: Correctly link riscv32e from platform-support.md

Correctly link the riscv32e platform support page.

Just a mistake during the iteration of rust-lang#130555 that was missed in review. Presumably the rv32e-none and rv32i-none pages eventually should get merged, but this is a relatively recent addition to the ISA definition so it is not clear the current RISCV Embedded group has the expertise on-hand... nor did it have their consent.
@rustbot rustbot added this to the 1.84.0 milestone Oct 27, 2024
@workingjubilee workingjubilee deleted the rv32e-platform-docs-mislinked branch October 28, 2024 06:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants