Skip to content

libtest: rename BenchHarness to Bencher #13236

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2014
Merged

libtest: rename BenchHarness to Bencher #13236

merged 1 commit into from
Apr 11, 2014

Conversation

liigo
Copy link
Contributor

@liigo liigo commented Apr 1, 2014

Closes #12640

based on PR #13030, rebased, and passed all tests.

@liigo
Copy link
Contributor Author

liigo commented Apr 1, 2014

@alexcrichton r?

bors added a commit that referenced this pull request Apr 1, 2014
@bors
auto merge of #13236 : liigo/rust/rename-benchharness, r=alexcrichton
8a4ee7b 
Closes #12640

based on PR #13030, rebased, and passed all tests.
@liigo
Copy link
Contributor Author

liigo commented Apr 3, 2014

Others had been changed some code after my last rebase, and been merged before this PR. I think this is the reason that this PR was merged fails. I just did another rebase. @alexcrichton

@liigo
Copy link
Contributor Author

liigo commented Apr 11, 2014

Rebased. @huonw @alexcrichton r?

@liigo
Copy link
Contributor Author

liigo commented Apr 11, 2014

@huonw @alexcrichton Can you help me? I really don't know why tests failed. Thank you!

task '<unnamed>' failed at 'assertion failed: *p != 0', /home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/c_str.rs:372

task '<unnamed>' failed at 'receiving on a closed channel', /home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/comm/mod.rs:668

task '<unnamed>' failed at 'sending on a closed channel', /home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/comm/mod.rs:583

task '<unnamed>' failed at 'sending on a closed channel', /home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/comm/mod.rs:437

task '<unnamed>' failed at 'called `Result::unwrap()` on an `Err` value', /home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/result.rs:187

task '<unnamed>' failed at 'assertion failed: !contains_nul(path.container_as_bytes())', /home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/path/mod.rs:161
task '<unnamed>' failed at 'assertion failed: !contains_nul(filename.container_as_bytes())', /home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/path/mod.rs:277
task '<unnamed>' failed at 'assertion failed: !contains_nul(path.container_as_bytes())', /home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/path/mod.rs:379

task '<unnamed>' failed at '~Any', /home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/task.rs:519
task '<unnamed>' failed at 'owned string', /home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/task.rs:505
task '<unnamed>' failed at 'static string', /home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/task.rs:491

task '<unnamed>' failed at 'assertion failed: `(left == right) && (right == left)` (left: `1`, right: `2`)', /home/rustbuild/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/libstd/unstable/sync.rs:152

@huonw
Copy link
Member

huonw commented Apr 11, 2014

I think that's just a spurious failure that's almost certainly not caused by these changes.

bors added a commit that referenced this pull request Apr 11, 2014
@bors
auto merge of #13236 : liigo/rust/rename-benchharness, r=huonw
8b6091e 
Closes #12640

based on PR #13030, rebased, and passed all tests.
@bors bors closed this Apr 11, 2014
@bors bors merged commit 408f484 into rust-lang:master Apr 11, 2014
@liigo liigo deleted the rename-benchharness branch April 15, 2014 09:30
flip1995 pushed a commit to flip1995/rust that referenced this pull request Aug 8, 2024
@bors
Auto merge of rust-lang#13236 - flip1995:rustup, r=flip1995
cb80611 
Rustup

r? `@ghost`

changelog: ICE fix [`uninit_vec`] through rust-lang#128720
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename test::BenchHarness to test::Bencher
4 participants
@liigo @huonw @alexcrichton @bors