Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

PassWrapper: adapt for llvm/llvm-project@b01e2a8b5620466c3b #132419

Merged
merged 1 commit into from
Nov 3, 2024
Merged

PassWrapper: adapt for llvm/llvm-project@b01e2a8b5620466c3b #132419

merged 1 commit into from
Nov 3, 2024

Conversation

durin42
Copy link
Contributor

@durin42 durin42 commented Oct 31, 2024

A boolean turned into an enum. None matches the old behavior of false, so we pass that.

@rustbot label: +llvm-main

@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2024

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) labels Oct 31, 2024
@rust-log-analyzer

This comment has been minimized.

# to view
@durin42 durin42 force-pushed the llvm-20-type-test-thing branch from 5762031 to 052ca60 Compare October 31, 2024 18:57
@durin42
PassWrapper: adapt for llvm/llvm-project@b01e2a8
ab5583e 
We don't see a reason to explicitly pass the default here, so just use
the default instead of explicitly passing it and needing an ifdef.

@rustbot label: +llvm-main
@durin42 durin42 force-pushed the llvm-20-type-test-thing branch from 052ca60 to ab5583e Compare November 2, 2024 18:40
@cuviper
Copy link
Member

cuviper commented Nov 2, 2024

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 2, 2024

📌 Commit ab5583e has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2024
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 2, 2024
@GuillaumeGomez
Rollup merge of rust-lang#132419 - durin42:llvm-20-type-test-thing, r…
6ac3071 
…=cuviper

PassWrapper: adapt for llvm/llvm-project@b01e2a8b5620466c3b

A boolean turned into an enum. None matches the old behavior of false, so we pass that.

`@rustbot` label: +llvm-main
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 2, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 2, 2024
@bors
Auto merge of rust-lang#132538 - GuillaumeGomez:rollup-nz2v8uj, r=Gui…
9597666 
…llaumeGomez

Rollup of 8 pull requests

Successful merges:

 - rust-lang#132153 (Stabilise `const_char_encode_utf16`.)
 - rust-lang#132419 (PassWrapper: adapt for llvm/llvm-project@b01e2a8b5620466c3b)
 - rust-lang#132437 (coverage: Regression test for inlining into an uninstrumented crate)
 - rust-lang#132458 (get rid of a whole bunch of unnecessary rustc_const_unstable attributes)
 - rust-lang#132520 (NFC add known bug nr to test)
 - rust-lang#132522 (make codegen help output more consistent)
 - rust-lang#132523 (Added regression test for generics index out of bounds)
 - rust-lang#132528 (Use `*_opt` typeck results fns to not ICE in fallback suggestion)

Failed merges:

 - rust-lang#132511 (stabilize const_arguments_as_str)

r? `@ghost`
`@rustbot` modify labels: rollup
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 2, 2024
@GuillaumeGomez
Rollup merge of rust-lang#132419 - durin42:llvm-20-type-test-thing, r…
9633dce 
…=cuviper

PassWrapper: adapt for llvm/llvm-project@b01e2a8b5620466c3b

A boolean turned into an enum. None matches the old behavior of false, so we pass that.

``@rustbot`` label: +llvm-main
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 2, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 2, 2024
@bors
Auto merge of rust-lang#132539 - GuillaumeGomez:rollup-4qi2bvk, r=Gui…
68b3608 
…llaumeGomez

Rollup of 7 pull requests

Successful merges:

 - rust-lang#132419 (PassWrapper: adapt for llvm/llvm-project@b01e2a8b5620466c3b)
 - rust-lang#132437 (coverage: Regression test for inlining into an uninstrumented crate)
 - rust-lang#132458 (get rid of a whole bunch of unnecessary rustc_const_unstable attributes)
 - rust-lang#132520 (NFC add known bug nr to test)
 - rust-lang#132522 (make codegen help output more consistent)
 - rust-lang#132523 (Added regression test for generics index out of bounds)
 - rust-lang#132528 (Use `*_opt` typeck results fns to not ICE in fallback suggestion)

Failed merges:

 - rust-lang#132511 (stabilize const_arguments_as_str)

r? `@ghost`
`@rustbot` modify labels: rollup
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Nov 2, 2024
@workingjubilee
Rollup merge of rust-lang#132419 - durin42:llvm-20-type-test-thing, r…
b32ecc2 
…=cuviper

PassWrapper: adapt for llvm/llvm-project@b01e2a8b5620466c3b

A boolean turned into an enum. None matches the old behavior of false, so we pass that.

```@rustbot``` label: +llvm-main
@workingjubilee workingjubilee mentioned this pull request Nov 2, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 3, 2024
@bors
Auto merge of rust-lang#132546 - workingjubilee:rollup-r9mkkhd, r=wor…
728065d 
…kingjubilee

Rollup of 12 pull requests

Successful merges:

 - rust-lang#132393 (Docs: added brief colon explanation)
 - rust-lang#132419 (PassWrapper: adapt for llvm/llvm-project@b01e2a8b5620466c3b)
 - rust-lang#132437 (coverage: Regression test for inlining into an uninstrumented crate)
 - rust-lang#132458 (get rid of a whole bunch of unnecessary rustc_const_unstable attributes)
 - rust-lang#132499 (unicode_data.rs: show command for generating file)
 - rust-lang#132503 (better test for const HashMap; remove const_hash leftovers)
 - rust-lang#132514 (Port most of `--print=target-cpus` to Rust)
 - rust-lang#132520 (NFC add known bug nr to test)
 - rust-lang#132522 (make codegen help output more consistent)
 - rust-lang#132523 (Added regression test for generics index out of bounds)
 - rust-lang#132526 (Subtree sync for rustc_codegen_cranelift)
 - rust-lang#132528 (Use `*_opt` typeck results fns to not ICE in fallback suggestion)
 - rust-lang#132540 (Do not format generic consts)

Failed merges:

 - rust-lang#132511 (stabilize const_arguments_as_str)

r? `@ghost`
`@rustbot` modify labels: rollup
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Nov 3, 2024
@workingjubilee
Rollup merge of rust-lang#132419 - durin42:llvm-20-type-test-thing, r…
740044c 
…=cuviper

PassWrapper: adapt for llvm/llvm-project@b01e2a8b5620466c3b

A boolean turned into an enum. None matches the old behavior of false, so we pass that.

````@rustbot```` label: +llvm-main
@workingjubilee workingjubilee mentioned this pull request Nov 3, 2024
Closed
@workingjubilee
Copy link
Member

workingjubilee commented Nov 3, 2024 •
edited
Loading

This one has been in a handful of rollups that failed for mysterious reasons during LLVM phases (PGO, etc.) and it's not ifdef'd to only affect LLVM_VERSION_MAJOR >= 20, so I'm being over-cautious and marking this

@bors rollup=iffy

@bors
Copy link
Contributor

bors commented Nov 3, 2024

⌛ Testing commit ab5583e with merge db034ce...

@bors
Copy link
Contributor

bors commented Nov 3, 2024

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing db034ce to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 3, 2024
@bors bors merged commit db034ce into rust-lang:master Nov 3, 2024
7 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 3, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (db034ce): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.2% [-0.2%, -0.2%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -0.2%, secondary 3.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.5% [3.5%, 3.5%] 1
Regressions ❌
(secondary)		 3.4% [3.4%, 3.4%] 1
Improvements ✅
(primary)		 -3.9% [-3.9%, -3.9%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.2% [-3.9%, 3.5%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 780.951s -> 779.49s (-0.19%)
Artifact size: 335.37 MiB -> 335.37 MiB (-0.00%)

@durin42 durin42 deleted the llvm-20-type-test-thing branch December 11, 2024 09:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cuviper cuviper cuviper left review comments

Assignees

@cuviper cuviper

Labels
llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
7 participants
@durin42 @rustbot @rust-log-analyzer @cuviper @bors @workingjubilee @rust-timer