Suggest creating unary tuples when types don't match a trait #132583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nnethercote rustbot has assigned @nnethercote. Use |
rustbot
added
S-waiting-on-review
mejrs
commented
Nov 4, 2024
Comment on lines
+17
to
+18
| LL | check(((),)); | ||
| | + ++ |
There was a problem hiding this comment.
Is this suggestion okay? I'm not quite sure what #[do_not_recommend] is supposed to (not) show. Its rfc only talks about not mentioning confusing traits.
This comment has been minimized.
This comment has been minimized.
compiler-errors
requested changes
Nov 4, 2024
Comment on lines
4462
to
4472
| self.infcx.enter_forall(trait_ref, |trait_ref| { | ||
| if self | ||
| .type_implements_trait(trait_ref.def_id, trait_ref.args, root_obligation.param_env) | ||
| .must_apply_modulo_regions() | ||
| { | ||
| err.multipart_suggestion_verbose( | ||
| format!("use a unary tuple instead"), | ||
| vec![(span.shrink_to_lo(), "(".into()), (span.shrink_to_hi(), ",)".into())], | ||
| Applicability::MaybeIncorrect, | ||
| ); | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
this is kinda unnecessary. instead of using enter_forall and calling type_implements_trait, just use predicate_must_hold_modulo_regions.
| obligation: &PredicateObligation<'tcx>, | ||
| span: Span, | ||
| ) { | ||
| if !matches!(obligation.cause.code(), ObligationCauseCode::FunctionArg { .. }) { |
There was a problem hiding this comment.
I would turn this into an if let ObligationCauseCode::FunctionArg { arg_hir_id, .. } = ....
Then use the span from arg_hir_id via tcx.hir.span(arg_hir_id). It may seem roundabout, but there's always a chance that the obligation span has been messed with, and getting the span from the actual arg expression is strictly more right...
rustbot
added
S-waiting-on-author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
compiler-errors
approved these changes
Nov 4, 2024
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 4, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#132355 (Fix compiler panic with a large number of threads) - rust-lang#132486 (No need to instantiate binder in `confirm_async_closure_candidate`) - rust-lang#132544 (Use backticks instead of single quotes for library feature names in diagnostics) - rust-lang#132559 (find the generic container rather than simply looking up for the assoc with const arg) - rust-lang#132579 (add rustc std workspace crate sources) - rust-lang#132583 (Suggest creating unary tuples when types don't match a trait) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 4, 2024
Rollup merge of rust-lang#132583 - mejrs:tuples, r=compiler-errors Suggest creating unary tuples when types don't match a trait When you want to have a variadic function, a common workaround to implement this is to create a trait and then implement that trait for various tuples. For example in `pyo3` there exists ```rust /// Calls the object with only positional arguments. pub fn call1(&self, args: impl IntoPy<Py<PyTuple>>) -> PyResult<&PyAny> { ... } ``` with various impls like ```rust impl<A: IntoPy<PyObject> IntoPy<Py<PyAny>> for (A,) impl<A: IntoPy<PyObject, B: IntoPy<PyObject> IntoPy<Py<PyAny>> for (A, B) ... etc ``` This means that if you want to call the method with a single item you have to create a unary tuple, like `(x,)`, rather than just `x`. This PR implements a suggestion to do that, if applicable.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you want to have a variadic function, a common workaround to implement this is to create a trait and then implement that trait for various tuples. For example in
pyo3there existswith various impls like
This means that if you want to call the method with a single item you have to create a unary tuple, like
(x,), rather than justx.This PR implements a suggestion to do that, if applicable.