Skip to content

Rollup of 3 pull requests #132703

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 6, 2024
Merged

Rollup of 3 pull requests #132703

merged 6 commits into from
Nov 6, 2024

Conversation

GuillaumeGomez
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

uellenberg and others added 6 commits November 5, 2024 16:11
@uellenberg
Change some code blocks to quotes in rendered std doc
934be9b 
Fixes rust-lang#132564
@GuillaumeGomez
Remove unneeded fields in scrape_examples::FindCalls
03a63fd
@matthiaskrgr
add note not to re-report crashes from crashes tests
da5102c
@GuillaumeGomez
Rollup merge of rust-lang#132617 - uellenberg:fix-rendered-doc, r=cuv…
d6a43d4 
…iper

Fix an extra newline in rendered std doc

Fixes rust-lang#132564

![17308581942254367500907812250579](https://github.com/user-attachments/assets/9e946c49-c0a6-40ba-ab69-b80fe0e085e1)
(taken from the issue above)

The problem with the formatting is due to that newline between `<code>` and `<svg>`. Any newlines outside of the code (i.e., within elements inside of it) are fine.
@GuillaumeGomez
Rollup merge of rust-lang#132698 - GuillaumeGomez:rm-unneeded-fields,…
d150498 
… r=notriddle

Remove unneeded fields in `scrape_examples::FindCalls`

Just a small cleanup while going through something bigger.

r? `@notriddle`
@GuillaumeGomez
Rollup merge of rust-lang#132700 - matthiaskrgr:plzno, r=fmease
4c7e92f 
add note not to re-report crashes from `crashes` tests

for reasons... 😅
r? `@fmease`
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Nov 6, 2024
@GuillaumeGomez
Copy link
Member Author

@bors r+ p=3 rollup=never

@bors
Copy link
Collaborator

bors commented Nov 6, 2024

📌 Commit 4c7e92f has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2024
@bors
Copy link
Collaborator

bors commented Nov 6, 2024

⌛ Testing commit 4c7e92f with merge 8549802...

@bors
Copy link
Collaborator

bors commented Nov 6, 2024

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 8549802 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 6, 2024
@bors bors merged commit 8549802 into rust-lang:master Nov 6, 2024
7 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 6, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#132617 Fix an extra newline in rendered std doc f1918d15bccb7275cda04bb3f7491173e904d963 (link)
#132698 Remove unneeded fields in scrape_examples::FindCalls 7d39c4b9380aa36a9347e845991c23828c8277f2 (link)
#132700 add note not to re-report crashes from crashes tests d3a8305de976feb546d4b31b544721fc9db245a1 (link)

previous master: 116fc31c5c

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@GuillaumeGomez GuillaumeGomez deleted the rollup-tfuef34 branch November 6, 2024 21:23
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8549802): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.2% [1.2%, 1.2%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.0% [-2.0%, -2.0%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.4% [-2.0%, 1.2%] 2

Cycles

Results (secondary 8.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 8.3% [7.4%, 9.4%] 6
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 781.215s -> 781.244s (0.00%)
Artifact size: 335.24 MiB -> 335.32 MiB (0.02%)

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @bors @rust-timer @rustbot @uellenberg @matthiaskrgr