Skip to content

Crater 2024 edition #132712

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Crater 2024 edition #132712

wants to merge 1 commit into from
+3 −2

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Nov 6, 2024

No description provided.

@ehuss ehuss self-assigned this Nov 6, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2024

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2024

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras

Some changes occurred in match lowering

cc @Nadrieril

Some changes occurred to the CTFE machinery

cc @rust-lang/wg-const-eval

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in coverage instrumentation.

cc @Zalathar

This PR changes Stable MIR

cc @oli-obk, @celinval, @ouz-a

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 6, 2024
@ehuss
Copy link
Contributor Author

ehuss commented Nov 6, 2024

@bors try

@bors
Copy link
Collaborator

bors commented Nov 6, 2024

⌛ Trying commit 3fd8c5a with merge da25749...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 6, 2024
@bors
Auto merge of rust-lang#132712 - ehuss:2024-crater, r=<try>
da25749 
Crater 2024 edition
@bors
Copy link
Collaborator

bors commented Nov 6, 2024

☀️ Try build successful - checks-actions
Build commit: da25749 (da25749bf5e6ba5ed862ff361c19afff2a986b2d)

@ehuss
Copy link
Contributor Author

ehuss commented Nov 6, 2024

@craterbot check cap-lints=allow p=5 crates=top-5000

@craterbot
Copy link
Collaborator

👌 Experiment pr-132712 created and queued.
🤖 Automatically detected try build da25749
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2024
celinval
celinval reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For StableMIR, I was wondering if it would be simpler to translate the new StatementKind to Nop for now. Thanks!

@ehuss
Copy link
Contributor Author

ehuss commented Nov 8, 2024

@celinval sorry for the confusion. The changes in this PR are not to be reviewed. It just contains a copy of #131326 for crater testing. If you have feedback, it would be best to leave it over there.

@celinval
Copy link
Contributor

celinval commented Nov 8, 2024

@celinval sorry for the confusion. The changes in this PR are not to be reviewed. It just contains a copy of #131326 for crater testing. If you have feedback, it would be best to leave it over there.

My bad. Not used to the automation yet. Thanks!

@craterbot
Copy link
Collaborator

🚧 Experiment pr-132712 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-132712 is completed!
📊 63 regressed and 315 fixed (5000 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Nov 9, 2024
@ehuss
Copy link
Contributor Author

ehuss commented Nov 23, 2024

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 23, 2024
@bors
Auto merge of rust-lang#132712 - ehuss:2024-crater, r=<try>
65132f3 
Crater 2024 edition
@bors
Copy link
Collaborator

bors commented Nov 23, 2024

⌛ Trying commit 2bb7e98 with merge 65132f3...

@bors
Copy link
Collaborator

bors commented Nov 23, 2024

☀️ Try build successful - checks-actions
Build commit: 65132f3 (65132f36b923285d5da381c2fbafee6ce899e841)

@ehuss
Copy link
Contributor Author

ehuss commented Nov 23, 2024

@craterbot check cap-lints=allow p=10

@craterbot
Copy link
Collaborator

👌 Experiment pr-132712-1 created and queued.
🤖 Automatically detected try build 65132f3
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 23, 2024
@craterbot
Copy link
Collaborator

🚧 Experiment pr-132712-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-132712-1 is completed!
📊 1255 regressed and 37375 fixed (542435 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Nov 26, 2024
@dingxiangfei2009 dingxiangfei2009 mentioned this pull request Dec 19, 2024
Draft
@workingjubilee workingjubilee added the C-crater Category: Issue for tracking crater runs label Feb 14, 2025
@Dylan-DPC Dylan-DPC added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@celinval celinval celinval left review comments

Assignees

@ehuss ehuss

Labels
C-crater Category: Issue for tracking crater runs S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ehuss @rustbot @bors @craterbot @celinval @workingjubilee @Dylan-DPC