Skip to content

CI: split x86_64-mingw job #132721

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2024
Merged

CI: split x86_64-mingw job #132721

merged 1 commit into from
Nov 30, 2024

Conversation

marcoieni
Copy link
Member

@marcoieni marcoieni commented Nov 7, 2024 •
edited
Loading

Split the x86_64-mingw job in two to move it to free runners and reduce the use of large runners in CI.

try-job: x86_64-mingw-1
try-job: x86_64-mingw-2

@rustbot
Copy link
Collaborator

rustbot commented Nov 7, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 7, 2024
@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Nov 7, 2024

⌛ Trying commit 59f649f with merge 5c29c17...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 7, 2024
@bors
Auto merge of rust-lang#132721 - MarcoIeni:mingw-split, r=<try>
5c29c17 
CI: split x86_64-mingw job

try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
@rust-log-analyzer

This comment has been minimized.

# to view
@bors
Copy link
Collaborator

bors commented Nov 7, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2024
@mati865
Copy link
Contributor

mati865 commented Nov 8, 2024 •
edited
Loading

NO_DOWNLOAD_CI_LLVM: 1 can be removed, I forgot about it when upgrading the toolchain.

That alone should shorten the time by a large amount.

@marcoieni
Copy link
Member Author

thanks! I will create a separate PR for this.
This environment variable is present in the following windows jobs:

  • i686-mingw
  • x86_64-mingw
  • dist-i686-mingw
  • dist-x86_64-mingw

Can I delete it for all of them?

@mati865
Copy link
Contributor

mati865 commented Nov 8, 2024

Yeah, they all should be fine to remove.

@marcoieni marcoieni mentioned this pull request Nov 8, 2024
Closed
@marcoieni
Copy link
Member Author

opened #132781 🙏

@marcoieni
Copy link
Member Author

Interestingly I found #112645 which does the opposite of this PR. My goal is to try to "revert" part of the PR by using two free runners.
I'll try bors again because I don't get why it failed. Maybe it's a flaky error.

@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Nov 14, 2024

⌛ Trying commit a3d3c42 with merge 92e5539...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2024
@bors
Auto merge of rust-lang#132721 - MarcoIeni:mingw-split, r=<try>
92e5539 
CI: split x86_64-mingw job

try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
@rust-log-analyzer

This comment has been minimized.

# to view
@bors
Copy link
Collaborator

bors commented Nov 14, 2024

💔 Test failed - checks-actions

@marcoieni
Copy link
Member Author

I'll give this one last try 🤔

@marcoieni
Copy link
Member Author

@bors try

@mati865
Copy link
Contributor

mati865 commented Nov 14, 2024 •
edited
Loading

This not a spurious failure, the linker is misconfigured.

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2024
@bors
Auto merge of rust-lang#132721 - MarcoIeni:mingw-split, r=<try>
89ca439 
CI: split x86_64-mingw job

try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
@bors
Copy link
Collaborator

bors commented Nov 14, 2024

⌛ Trying commit a3d3c42 with merge 89ca439...

@marcoieni
Copy link
Member Author

This not a spurious failure, the linker is misconfigured.

ok, thank you. Is there something I'm missing? Because I don't understand what I did wrong

@marcoieni
Copy link
Member Author

Maybe make ci-mingw-x does some work required for make ci-mingw-bootstrap, too?

@bors
Copy link
Collaborator

bors commented Nov 28, 2024

☀️ Try build successful - checks-actions
Build commit: c1f6bfa (c1f6bfa98f8f877551a883db83769468070e0419)

@marcoieni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2024
@bors
Auto merge of rust-lang#132721 - MarcoIeni:mingw-split, r=<try>
f19b2bc 
CI: split x86_64-mingw job

try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
@bors
Copy link
Collaborator

bors commented Nov 29, 2024

⌛ Trying commit c1924f4 with merge f19b2bc...

@bors
Copy link
Collaborator

bors commented Nov 29, 2024

☀️ Try build successful - checks-actions
Build commit: f19b2bc (f19b2bc74989c837585ac79667279b724fb0e950)

@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Nov 29, 2024

⌛ Trying commit 30a9fdc with merge e2c0be6...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2024
@bors
Auto merge of rust-lang#132721 - MarcoIeni:mingw-split, r=<try>
e2c0be6 
CI: split x86_64-mingw job

try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
@bors
Copy link
Collaborator

bors commented Nov 29, 2024

☀️ Try build successful - checks-actions
Build commit: e2c0be6 (e2c0be648f14046dc2efd861b28b3fa4ce131f2c)

@marcoieni
Copy link
Member Author

Yay, this looks good
image

@marcoieni
Copy link
Member Author

force pushed, updated with master. Now I'm running bors try for the last time to check if everything is still ok 👍

@marcoieni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2024
@bors
Auto merge of rust-lang#132721 - MarcoIeni:mingw-split, r=<try>
51892e7 
CI: split x86_64-mingw job

try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
@bors
Copy link
Collaborator

bors commented Nov 29, 2024

⌛ Trying commit 5b9a77a with merge 51892e7...

@bors
Copy link
Collaborator

bors commented Nov 29, 2024

☀️ Try build successful - checks-actions
Build commit: 51892e7 (51892e71fdf01ee420b6d88c214ff18001c08d0a)

@marcoieni
Copy link
Member Author

image

@marcoieni marcoieni marked this pull request as ready for review November 29, 2024 17:55
@Kobzol
Copy link
Contributor

Kobzol commented Nov 29, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 29, 2024

📌 Commit 5b9a77a has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 29, 2024
@jieyouxu jieyouxu mentioned this pull request Nov 30, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 30, 2024
@bors
Auto merge of rust-lang#133659 - jieyouxu:rollup-576gh4p, r=jieyouxu
3339c52 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#131551 (Support input/output in vector registers of PowerPC inline assembly)
 - rust-lang#132515 (Fix and undeprecate home_dir())
 - rust-lang#132721 (CI: split x86_64-mingw job)
 - rust-lang#133106 (changes old intrinsic declaration to new declaration)
 - rust-lang#133496 (thread::available_parallelism for wasm32-wasip1-threads)
 - rust-lang#133548 (Add `BTreeSet` entry APIs to match `HashSet`)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 30, 2024
@bors
Auto merge of rust-lang#133659 - jieyouxu:rollup-576gh4p, r=jieyouxu
f981b2e 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#131551 (Support input/output in vector registers of PowerPC inline assembly)
 - rust-lang#132515 (Fix and undeprecate home_dir())
 - rust-lang#132721 (CI: split x86_64-mingw job)
 - rust-lang#133106 (changes old intrinsic declaration to new declaration)
 - rust-lang#133496 (thread::available_parallelism for wasm32-wasip1-threads)
 - rust-lang#133548 (Add `BTreeSet` entry APIs to match `HashSet`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 34256fe into rust-lang:master Nov 30, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Nov 30, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 30, 2024
@rust-timer
Unrolled build for rust-lang#132721
30a320b 
Rollup merge of rust-lang#132721 - MarcoIeni:mingw-split, r=Kobzol

CI: split x86_64-mingw job

try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request Mar 11, 2025
@bors
Auto merge of rust-lang#133659 - jieyouxu:rollup-576gh4p, r=jieyouxu
9866fb3 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#131551 (Support input/output in vector registers of PowerPC inline assembly)
 - rust-lang#132515 (Fix and undeprecate home_dir())
 - rust-lang#132721 (CI: split x86_64-mingw job)
 - rust-lang#133106 (changes old intrinsic declaration to new declaration)
 - rust-lang#133496 (thread::available_parallelism for wasm32-wasip1-threads)
 - rust-lang#133548 (Add `BTreeSet` entry APIs to match `HashSet`)

r? `@ghost`
`@rustbot` modify labels: rollup
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Kobzol Kobzol Kobzol left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
8 participants
@marcoieni @rustbot @bors @rust-log-analyzer @mati865 @Kobzol @Mark-Simulacrum @jieyouxu