require const_impl_trait gate for all conditional and trait const calls #132823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the CTFE machinery cc @rust-lang/wg-const-eval |
RalfJung
force-pushed
the
conditional-const-calls
branch
2 times, most recently
from
8dacead to
516b385
Compare
RalfJung
commented
Nov 9, 2024
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
conditional-const-calls
branch
3 times, most recently
from
72898b3 to
996a8e4
Compare
RalfJung
force-pushed
the
conditional-const-calls
branch
from
996a8e4 to
822762c
Compare
fee1-dead
approved these changes
Nov 10, 2024
compiler-errors
approved these changes
Nov 10, 2024
|
@bors r=fee1-dead,compiler-errors rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 10, 2024
…kingjubilee Rollup of 6 pull requests Successful merges: - rust-lang#131258 (Stabilize s390x inline assembly) - rust-lang#132801 (interpret: get_alloc_info: also return mutability) - rust-lang#132823 (require const_impl_trait gate for all conditional and trait const calls) - rust-lang#132824 (Update grammar in wasm-c-abi's compiler flag documentation) - rust-lang#132825 (Exclude relnotes-tracking-issue from needs-triage) - rust-lang#132828 (Additional tests to ensure let is rejected during parsing) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 10, 2024
Rollup merge of rust-lang#132823 - RalfJung:conditional-const-calls, r=fee1-dead,compiler-errors require const_impl_trait gate for all conditional and trait const calls Alternative to rust-lang#132786. `@compiler-errors` this is basically what I meant with my proposals. I found it's easier to express this in code than English. ;) r? `@compiler-errors`
mati865
pushed a commit
to mati865/rust
that referenced
this pull request
Nov 12, 2024
…r=fee1-dead,compiler-errors require const_impl_trait gate for all conditional and trait const calls Alternative to rust-lang#132786. `@compiler-errors` this is basically what I meant with my proposals. I found it's easier to express this in code than English. ;) r? `@compiler-errors`
mati865
pushed a commit
to mati865/rust
that referenced
this pull request
Nov 12, 2024
…kingjubilee Rollup of 6 pull requests Successful merges: - rust-lang#131258 (Stabilize s390x inline assembly) - rust-lang#132801 (interpret: get_alloc_info: also return mutability) - rust-lang#132823 (require const_impl_trait gate for all conditional and trait const calls) - rust-lang#132824 (Update grammar in wasm-c-abi's compiler flag documentation) - rust-lang#132825 (Exclude relnotes-tracking-issue from needs-triage) - rust-lang#132828 (Additional tests to ensure let is rejected during parsing) r? `@ghost` `@rustbot` modify labels: rollup
14 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #132786.
@compiler-errors this is basically what I meant with my proposals. I found it's easier to express this in code than English. ;)
r? @compiler-errors