Skip to content

Rollup of 4 pull requests #132827

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 11 commits into from

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Urgau and others added 11 commits November 3, 2024 21:05
…nieu

Stabilize s390x inline assembly

This stabilizes inline assembly for s390x (SystemZ).

Corresponding reference PR: rust-lang/reference#1643

---

From the requirements of stabilization mentioned in rust-lang#93335

> Each architecture needs to be reviewed before stabilization:

> - It must have clobber_abi.

Done in rust-lang#130630.

> - It must be possible to clobber every register that is normally clobbered by a function call.

Done in the PR that added support for clobber_abi.

> - Generally review that the exposed register classes make sense.

The followings can be used as input/output:

- `reg` (`r[0-10]`, `r[12-14]`): General-purpose register

- `reg_addr` (`r[1-10]`, `r[12-14]`): General-purpose register except `r0` which is evaluated as zero in an address context

  This class is needed because `r0`, which may be allocated when using the `reg` class, cannot be used as a register in certain contexts. This is identical to the `a` constraint in LLVM and GCC. See rust-lang#119431 for details.

- `freg` (`f[0-15]`): Floating-point register

The followings are clobber-only:

- `vreg` (`v[0-31]`): Vector register

  Technically `vreg` should be able to accept `#[repr(simd)]` types as input/output if the unstable `vector` target feature added is enabled, but `core::arch` has no s390x vector type and both `#[repr(simd)]` and `core::simd` are unstable. Everything related is unstable, so the fact that this is currently a clobber-only should not be considered a stabilization blocker. (rust-lang#130869 tracks unstable stuff here)

- `areg` (`a[2-15]`): Access register

All of the above register classes except `reg_addr` are needed for `clobber_abi`.

The followings cannot be used as operands for inline asm (see also [getReservedRegs](https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0/llvm/lib/Target/SystemZ/SystemZRegisterInfo.cpp#L258-L282) and [SystemZELFRegisters](https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0/llvm/lib/Target/SystemZ/SystemZRegisterInfo.h#L107-L128) in LLVM):

- `r11`: frame pointer
- `r15`: stack pointer
- `a0`, `a1`: Reserved for system use
- `c[0-15]` (control register)  Reserved by the kernel

Although not listed in the above requirements, `preserves_flags` is implemented in rust-lang#111331.

---

cc `@uweigand`

r? `@Amanieu`

`@rustbot` label +O-SystemZ +A-inline-assembly
…o, r=petrochenkov

Report the `unexpected_cfgs` lint in external macros

This PR marks the `unexpected_cfgs` lint as being reportable in external macros, as it's probably not the intention of the macro author to leave ineffective cfgs in the users code.

Fixes rust-lang#132572
interpret: get_alloc_info: also return mutability

This will be needed for rust-lang/miri#3971

This then tuned into a larger refactor where we introduce a new type for the `get_alloc_info` return data, and we move some code to methods on `GlobalAlloc` to avoid duplicating it between the validity check and `get_alloc_info`.
…bby789

Exclude relnotes-tracking-issue from needs-triage
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Nov 9, 2024
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=4

@bors
Copy link
Collaborator

bors commented Nov 9, 2024

📌 Commit 36fc3d8 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2024
@bors
Copy link
Collaborator

bors commented Nov 9, 2024

⌛ Testing commit 36fc3d8 with merge 9812618...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 9, 2024
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#131258 (Stabilize s390x inline assembly)
 - rust-lang#132577 (Report the `unexpected_cfgs` lint in external macros)
 - rust-lang#132801 (interpret: get_alloc_info: also return mutability)
 - rust-lang#132825 (Exclude relnotes-tracking-issue from needs-triage)

r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu-debug failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling xtask v0.1.0 (/checkout/src/tools/rust-analyzer/xtask)
error: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs:348:15
    |
346 | macro_rules! cmd {
    | ---------------- in this expansion of `cmd!`
347 |     ($sh:expr, $cmd:literal) => {{
348 |         #[cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)]
    |
   ::: xtask/src/codegen/lints.rs:22:9
    |
    |
22  |         cmd!(sh, "git -C {rust_repo} pull --rebase").run().unwrap();
    |
    |
    = help: expected names are: `bootstrap`, `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `fmt_debug`, `llvm_enzyme`, `miri`, `overflow_checks`, `panic`, `parallel_compiler`, `proc_macro`, `relocation_model`, `rust_analyzer`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, and `ub_checks` and 2 more
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs`
    = note: `-D unexpected-cfgs` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(unexpected_cfgs)]`

error: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`
error: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs:348:15
    |
346 | macro_rules! cmd {
    | ---------------- in this expansion of `cmd!`
347 |     ($sh:expr, $cmd:literal) => {{
348 |         #[cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)]
    |
   ::: xtask/src/codegen/lints.rs:24:9
    |
    |
24  |         cmd!(sh, "git clone --depth=1 https://github.com/rust-lang/rust {rust_repo}")
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs`

error: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs:348:15
    |
    |
346 |   macro_rules! cmd {
    |   ---------------- in this expansion of `cmd!`
347 |       ($sh:expr, $cmd:literal) => {{
348 |           #[cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)]
    |
   ::: xtask/src/codegen/lints.rs:29:5
    |
29  | /     cmd!(
29  | /     cmd!(
30  | |         sh,
31  | |         "git -C {rust_repo} submodule update --init --recursive --depth=1 --
32  | |          compiler library src/tools src/doc/book"
    | |_____- in this macro invocation
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs`

error: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs:348:15
    |
    |
346 |   macro_rules! cmd {
    |   ---------------- in this expansion of `cmd!`
347 |       ($sh:expr, $cmd:literal) => {{
348 |           #[cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)]
    |
   ::: xtask/src/codegen/lints.rs:58:5
    |
58  | /     cmd!(
58  | /     cmd!(
59  | |         sh,
60  | |         "{cargo} run --manifest-path {rust_repo}/src/tools/unstable-book-gen/Cargo.toml --
61  | |          {rust_repo}/library {rust_repo}/compiler {rust_repo}/src {unstable_book}"
    | |_____- in this macro invocation
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs`

error: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs:348:15
    |
    |
346 |   macro_rules! cmd {
    |   ---------------- in this expansion of `cmd!`
347 |       ($sh:expr, $cmd:literal) => {{
348 |           #[cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)]
    |
   ::: xtask/src/codegen/lints.rs:69:5
    |
69  | /     cmd!(
69  | /     cmd!(
70  | |         sh,
71  | |         "curl https://rust-lang.github.io/rust-clippy/master/lints.json --output {lints_json}"
    | |_____- in this macro invocation
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs`

error: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs:348:15
    |
    |
346 | macro_rules! cmd {
    | ---------------- in this expansion of `cmd!`
347 |     ($sh:expr, $cmd:literal) => {{
348 |         #[cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)]
    |
   ::: xtask/src/codegen/lints.rs:111:18
    |
    |
111 |     let stdout = cmd!(sh, "rustdoc -Whelp").read().unwrap();
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs`

error: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs:348:15
    |
    |
346 | macro_rules! cmd {
    | ---------------- in this expansion of `cmd!`
347 |     ($sh:expr, $cmd:literal) => {{
348 |         #[cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)]
    |
   ::: xtask/src/codegen.rs:132:19
    |
    |
132 |     let version = cmd!(sh, "rustup run stable rustfmt --version").read().unwrap_or_default();
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs`

error: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs:348:15
    |
    |
346 | macro_rules! cmd {
    | ---------------- in this expansion of `cmd!`
347 |     ($sh:expr, $cmd:literal) => {{
348 |         #[cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)]
    |
   ::: xtask/src/codegen.rs:137:23
    |
    |
137 |         let version = cmd!(sh, "rustfmt --version").read().unwrap_or_default();
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs`

error: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs:348:15
    |
    |
346 | macro_rules! cmd {
    | ---------------- in this expansion of `cmd!`
347 |     ($sh:expr, $cmd:literal) => {{
348 |         #[cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)]
    |
   ::: xtask/src/codegen.rs:144:13
    |
    |
144 |             cmd!(sh, "rustfmt --config-path {rustfmt_toml} --config fn_single_line=true")
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs`

error: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs:348:15
    |
    |
346 |   macro_rules! cmd {
    |   ---------------- in this expansion of `cmd!`
347 |       ($sh:expr, $cmd:literal) => {{
348 |           #[cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)]
    |
   ::: xtask/src/codegen.rs:150:9
    |
150 | /         cmd!(
150 | /         cmd!(
151 | |             sh,
152 | |             "rustup run stable rustfmt --config-path {rustfmt_toml} --config fn_single_line=true"
    | |_________- in this macro invocation
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs`

error: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs:348:15
    |
    |
346 | macro_rules! cmd {
    | ---------------- in this expansion of `cmd!`
347 |     ($sh:expr, $cmd:literal) => {{
348 |         #[cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)]
    |
   ::: xtask/src/dist.rs:101:5
    |
    |
101 |     cmd!(sh, "cargo build --manifest-path ./crates/rust-analyzer/Cargo.toml --bin rust-analyzer --target {target_name} {features...} --release").ru...
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs`

error: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs:348:15
    |
    |
346 | macro_rules! cmd {
    | ---------------- in this expansion of `cmd!`
347 |     ($sh:expr, $cmd:literal) => {{
348 |         #[cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)]
    |
   ::: xtask/src/install.rs:78:9
    |
    |
78  |         cmd!(sh, "npm --version").run().context("`npm` is required to build the VS Code plugin")?;
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs`

error: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs:348:15
    |
    |
346 | macro_rules! cmd {
    | ---------------- in this expansion of `cmd!`
347 |     ($sh:expr, $cmd:literal) => {{
348 |         #[cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)]
    |
   ::: xtask/src/install.rs:79:9
    |
    |
79  |         cmd!(sh, "npm ci").run()?;
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs`

error: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs:348:15
    |
    |
346 | macro_rules! cmd {
    | ---------------- in this expansion of `cmd!`
347 |     ($sh:expr, $cmd:literal) => {{
348 |         #[cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)]
    |
   ::: xtask/src/install.rs:81:9
    |
    |
81  |         cmd!(sh, "npm run package --scripts-prepend-node-path").run()?;
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs`

error: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs:348:15
    |
    |
346 | macro_rules! cmd {
    | ---------------- in this expansion of `cmd!`
347 |     ($sh:expr, $cmd:literal) => {{
348 |         #[cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)]
    |
   ::: xtask/src/install.rs:83:9
    |
    |
83  |         cmd!(sh, "cmd.exe /c npm --version")
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs`

error: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs:348:15
    |
    |
346 | macro_rules! cmd {
    | ---------------- in this expansion of `cmd!`
347 |     ($sh:expr, $cmd:literal) => {{
348 |         #[cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)]
    |
   ::: xtask/src/install.rs:86:9
    |
    |
86  |         cmd!(sh, "cmd.exe /c npm ci").run()?;
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs`

error: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs:348:15
    |
    |
346 | macro_rules! cmd {
    | ---------------- in this expansion of `cmd!`
347 |     ($sh:expr, $cmd:literal) => {{
348 |         #[cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)]
    |
   ::: xtask/src/install.rs:88:9
    |
    |
88  |         cmd!(sh, "cmd.exe /c npm run package").run()?;
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs`

error: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs:348:15
    |
    |
346 | macro_rules! cmd {
    | ---------------- in this expansion of `cmd!`
347 |     ($sh:expr, $cmd:literal) => {{
348 |         #[cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)]
    |
   ::: xtask/src/install.rs:105:17
    |
    |
105 |                 cmd!(sh, "{bin} --version").read().is_ok()
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs`

error: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs:348:15
    |
    |
346 | macro_rules! cmd {
    | ---------------- in this expansion of `cmd!`
347 |     ($sh:expr, $cmd:literal) => {{
348 |         #[cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)]
    |
   ::: xtask/src/install.rs:107:17
    |
    |
107 |                 cmd!(sh, "cmd.exe /c {bin}.cmd --version").read().is_ok()
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs`

error: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs:348:15
    |
    |
346 | macro_rules! cmd {
    | ---------------- in this expansion of `cmd!`
347 |     ($sh:expr, $cmd:literal) => {{
348 |         #[cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)]
    |
   ::: xtask/src/install.rs:116:9
    |
    |
116 |         cmd!(sh, "{code} --install-extension rust-analyzer.vsix --force").run()?;
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs`

error: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs:348:15
    |
    |
346 | macro_rules! cmd {
    | ---------------- in this expansion of `cmd!`
347 |     ($sh:expr, $cmd:literal) => {{
348 |         #[cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)]
    |
   ::: xtask/src/install.rs:117:9
    |
    |
117 |         cmd!(sh, "{code} --list-extensions").read()?
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs`

error: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs:348:15
    |
    |
346 | macro_rules! cmd {
    | ---------------- in this expansion of `cmd!`
347 |     ($sh:expr, $cmd:literal) => {{
348 |         #[cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)]
    |
   ::: xtask/src/install.rs:119:9
    |
    |
119 |         cmd!(sh, "cmd.exe /c {code}.cmd --install-extension rust-analyzer.vsix --force").run()?;
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs`

error: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs:348:15
    |
    |
346 | macro_rules! cmd {
    | ---------------- in this expansion of `cmd!`
347 |     ($sh:expr, $cmd:literal) => {{
348 |         #[cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)]
    |
   ::: xtask/src/install.rs:120:9
    |
    |
120 |         cmd!(sh, "cmd.exe /c {code}.cmd --list-extensions").read()?
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs`

@bors
Copy link
Collaborator

bors commented Nov 10, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 10, 2024
@matthiaskrgr matthiaskrgr deleted the rollup-htfd66y branch January 25, 2025 09:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants