triagebot: Assign rustdoc tests to T-rustdoc. #132878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rustbot
added
A-meta
| @@ -1185,6 +1185,12 @@ project-exploit-mitigations = [ | |||
| "/src/rustdoc-json-types" = ["rustdoc"] | |||
| "/src/stage0" = ["bootstrap"] | |||
| "/tests/run-make" = ["@jieyouxu"] | |||
| "/tests/rustdoc" = ["rustdoc"] | |||
| "/tests/rustdoc-gui" = ["rustdoc"] | |||
There was a problem hiding this comment.
Is rustdoc-ui group working in this file? Because if so I think it would make more sense here and for the search tests (js and js-std).
There was a problem hiding this comment.
Yes this one. Got confused with the label. ^^'
There was a problem hiding this comment.
Is rustdoc-ui group working in this file?
Nope, we only have one for all of rustdoc.
Lines 1028 to 1032 in 2128d8d
| "/tests/rustdoc-gui" = ["rustdoc"] | ||
| "/tests/rustdoc-js-std" = ["rustdoc"] | ||
| "/tests/rustdoc-js" = ["rustdoc"] | ||
| "/tests/rustdoc-json" = ["@aDotInTheVoid"] |
There was a problem hiding this comment.
We should really have a rustdoc-json group at some point. Might be worth debating later on. ;)
GuillaumeGomez
approved these changes
Nov 10, 2024
|
Looks all good to me, thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 11, 2024
Rollup of 3 pull requests Successful merges: - rust-lang#131080 (Stabilize WebAssembly `multivalue`, `reference-types`, and `tail-call` target features) - rust-lang#132871 (add regression test for rust-lang#85763) - rust-lang#132878 (triagebot: Assign rustdoc tests to T-rustdoc.) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 11, 2024
Rollup merge of rust-lang#132878 - aDotInTheVoid:less-pings-for-mark, r=GuillaumeGomez triagebot: Assign rustdoc tests to T-rustdoc. Should avoid situations like rust-lang#132871, which got assigned to mark (via fallback) despite being a rustdoc change. For now, I've assigned all our testsuites to the rustdoc group (whoever from T-Rustdoc is on review rotation), except the json one which is assigned to me. CC `@rust-lang/rustdoc` r? `@GuillaumeGomez`
mati865
pushed a commit
to mati865/rust
that referenced
this pull request
Nov 12, 2024
… r=GuillaumeGomez triagebot: Assign rustdoc tests to T-rustdoc. Should avoid situations like rust-lang#132871, which got assigned to mark (via fallback) despite being a rustdoc change. For now, I've assigned all our testsuites to the rustdoc group (whoever from T-Rustdoc is on review rotation), except the json one which is assigned to me. CC `@rust-lang/rustdoc` r? `@GuillaumeGomez`
mati865
pushed a commit
to mati865/rust
that referenced
this pull request
Nov 12, 2024
Rollup of 3 pull requests Successful merges: - rust-lang#131080 (Stabilize WebAssembly `multivalue`, `reference-types`, and `tail-call` target features) - rust-lang#132871 (add regression test for rust-lang#85763) - rust-lang#132878 (triagebot: Assign rustdoc tests to T-rustdoc.) r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should avoid situations like #132871, which got assigned to mark (via fallback) despite being a rustdoc change.
For now, I've assigned all our testsuites to the rustdoc group (whoever from T-Rustdoc is on review rotation), except the json one which is assigned to me.
CC @rust-lang/rustdoc
r? @GuillaumeGomez