For expr return (_ = 42); unused_paren lint should not be triggered
#132936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Nadrieril rustbot has assigned @Nadrieril. Use |
rustbot
added
S-waiting-on-review
Nadrieril
reviewed
Nov 12, 2024
tests/ui/lint/unused/unused-parens-assign-expr-in-ret-issue-131989.rs
Outdated
Show resolved
Hide resolved
|
@rustbot author |
rustbot
added
S-waiting-on-author
…usedBraces` checking `break`
rustbot
added
S-waiting-on-review
|
Looks good, thank you! @bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 15, 2024
For expr `return (_ = 42);` unused_paren lint should not be triggered fixes rust-lang#131989
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 15, 2024
For expr `return (_ = 42);` unused_paren lint should not be triggered fixes rust-lang#131989
This was referenced Nov 15, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 15, 2024
…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#132936 (For expr `return (_ = 42);` unused_paren lint should not be triggered) - rust-lang#132956 (Add visit_coroutine_kind to ast::Visitor) - rust-lang#132978 (Mention both release *and* edition breakage for never type lints) - rust-lang#133074 (make UI test OS-agnostic) - rust-lang#133080 (Fix span edition for 2024 RPIT coming from an external macro ) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 16, 2024
Rollup merge of rust-lang#132936 - surechen:fix_131989, r=Nadrieril For expr `return (_ = 42);` unused_paren lint should not be triggered fixes rust-lang#131989
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #131989