Skip to content

Unvacation myself #132998

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2024
Merged

Unvacation myself #132998

merged 1 commit into from
Nov 14, 2024

Conversation

jieyouxu
Copy link
Member

r? @ghost

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2024
@rustbot

This comment was marked as duplicate.

# to view
@jieyouxu
Copy link
Member Author

It turns out it was more annoying than helpful lol.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 13, 2024

📌 Commit 29889cc has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 13, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2024
@bors
Auto merge of rust-lang#133006 - matthiaskrgr:rollup-dz6oiq5, r=matth…
bd0826a 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#126046 (Implement `mixed_integer_ops_unsigned_sub`)
 - rust-lang#132302 (rustdoc: Treat declarative macros more like other item kinds)
 - rust-lang#132842 (ABI checks: add support for tier2 arches)
 - rust-lang#132995 (compiletest: Add ``exact-llvm-major-version`` directive)
 - rust-lang#132996 (Trim extra space when suggesting removing bad `let`)
 - rust-lang#132998 (Unvacation myself)
 - rust-lang#133000 ([rustdoc] Fix duplicated footnote IDs)
 - rust-lang#133001 (actually test next solver)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 59c5d7d into rust-lang:master Nov 14, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 14, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2024
@rust-timer
Unrolled build for rust-lang#132998
12c44d1 
Rollup merge of rust-lang#132998 - jieyouxu:undo-vacation, r=jieyouxu

Unvacation myself

r? `@ghost`
@jieyouxu jieyouxu deleted the undo-vacation branch November 14, 2024 07:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jieyouxu @rustbot @bors