Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add myself into users_on_vacation on triagebot #133036

Merged
merged 1 commit into from
Nov 14, 2024
Merged

add myself into users_on_vacation on triagebot #133036

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions triagebot.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -977,6 +977,7 @@ contributing_url = "https://rustc-dev-guide.rust-lang.org/getting-started.html"
users_on_vacation = [
"jyn514",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They don't seem to appear anywhere in this file, so I removed them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jyn is on alumni status so yeah

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that jyn wanted to remain there to avoid rustbot pings, IIRC, as some people were still pinging jyn months after they stopped actively working on the Project.

(somewhat ironically) @jyn514 Do you still want to be in this list?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does rustbot ping people that aren't in the triagebot file? That sounds weird 🤔

Copy link
Member

@jieyouxu jieyouxu Nov 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right good point, I think people can still r/? jyn otherwise?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at the time i left you couldn’t assign PRs to people outside the org. if that’s still the case i'm happy for you to remove me from this list.

"oli-obk",
"onur-ozkan",
]

[assign.adhoc_groups]
Expand Down
Loading