Skip to content

Fix LLVM target triple for x86_64-win7-windows-msvc #133239

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2024
Merged

Fix LLVM target triple for x86_64-win7-windows-msvc #133239

merged 1 commit into from
Nov 20, 2024

Conversation

kleisauke
Copy link
Contributor

The vendor field needs to be pc rather than win7.

@kleisauke
Fix LLVM target triple for x86_64-win7-windows-msvc
57ed8e8 
The vendor field needs to be `pc` rather than `win7`.
@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2024

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 20, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2024

These commits modify compiler targets.
(See the Target Tier Policy.)

@kleisauke
Copy link
Contributor Author

Context: rust-lang/cc-rs#1176 (comment).

@kleisauke kleisauke mentioned this pull request Nov 20, 2024
Merged
@jieyouxu
Copy link
Member

cc target maintainer @roblabla

@Nadrieril
Copy link
Member

r? compiler

@rustbot rustbot assigned lcnr and unassigned Nadrieril Nov 20, 2024
@ChrisDenton
Copy link
Member

This is correct. LLVM does not (ab)use the vendor field like we do. I thought we'd fixed this before but I must be misremembering.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 20, 2024

📌 Commit 57ed8e8 has been approved by ChrisDenton

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2024
@jieyouxu jieyouxu assigned ChrisDenton and unassigned lcnr Nov 20, 2024
@roblabla
Copy link
Contributor

roblabla commented Nov 20, 2024 •
edited
Loading

Ah yes, this is my bad, some copy paste fail when I first defined the targets, which I forgot to fix ^^'.

👍

@matthiaskrgr matthiaskrgr mentioned this pull request Nov 20, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2024
@bors
Auto merge of rust-lang#133251 - matthiaskrgr:rollup-gjeis3q, r=matth…
a1f2999 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#131904 (Stabilize const_pin_2)
 - rust-lang#133239 (Fix LLVM target triple for `x86_64-win7-windows-msvc`)
 - rust-lang#133241 (interpret: make typing_env field private)

r? `@ghost`
`@rustbot` modify labels: rollup
@mati865
Copy link
Member

mati865 commented Nov 20, 2024

This is correct. LLVM does not (ab)use the vendor field like we do. I thought we'd fixed this before but I must be misremembering.

I had noticed this problem in the cc-rs repo where you were pinged for the discussion, but nothing has been done about it until now.

@bors bors merged commit d332656 into rust-lang:master Nov 20, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 20, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2024
@rust-timer
Unrolled build for rust-lang#133239
3761805 
Rollup merge of rust-lang#133239 - kleisauke:fix-llvm-triple-x86_64-win7-windows-msvc, r=ChrisDenton

Fix LLVM target triple for `x86_64-win7-windows-msvc`

The vendor field needs to be `pc` rather than `win7`.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@roblabla roblabla roblabla approved these changes

Assignees

@ChrisDenton ChrisDenton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
9 participants
@kleisauke @rustbot @jieyouxu @Nadrieril @ChrisDenton @bors @roblabla @mati865 @lcnr