Disarm time 💣 (diagnostics)
#133245
Closed
Disarm time 💣 (diagnostics)
#133245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jieyouxu
added
the
S-blocked
rustbot
added
S-waiting-on-review
jieyouxu
removed
the
S-waiting-on-review
|
now we need a second timer to remind us to merge this 😄 |
jieyouxu
force-pushed
the
disarm-time-bomb
branch
from
9fe05c0 to
58a0bc5
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
jieyouxu
force-pushed
the
disarm-time-bomb
branch
2 times, most recently
from
61c02cb to
2f2fc50
Compare
jieyouxu
changed the title
time bomb (diagnostics)time 💣 (diagnostics)
|
☔ The latest upstream changes (presumably #138464) made this pull request unmergeable. Please resolve the merge conflicts. |
jieyouxu
force-pushed
the
disarm-time-bomb
branch
from
2f2fc50 to
9a6a705
Compare
|
☔ The latest upstream changes (presumably #140520) made this pull request unmergeable. Please resolve the merge conflicts. |
Manually revert rust-lang#129343 `time` diagnostics, which is a temporary diagnostic to mitigate inference breakage fallout.
jieyouxu
changed the title
time 💣 (diagnostics)time 💣 (diagnostics)
|
(Already rolled into #140839) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #129461.
Manually reverts Emit specific message for time<=0.3.35 #129343 to defuse a time 💣.