Skip to content

Parse guard patterns #133424

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 9, 2024
Merged

Parse guard patterns #133424

merged 8 commits into from
Dec 9, 2024

Conversation

Nadrieril
Copy link
Member

@Nadrieril Nadrieril commented Nov 24, 2024 •
edited
Loading

This implements the parsing of RFC3637 Guard Patterns (see also tracking issue). This PR is extracted from #129996 with minor modifications.

cc @max-niederman

@rustbot
Copy link
Collaborator

rustbot commented Nov 24, 2024

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 24, 2024
@Nadrieril Nadrieril mentioned this pull request Nov 24, 2024
Open
8 tasks
@rust-log-analyzer

This comment has been minimized.

# to view
@rust-log-analyzer

This comment has been minimized.

# to view
@Nadrieril Nadrieril force-pushed the guard-patterns-parsing branch from 6f2c8e0 to 962c014 Compare November 24, 2024 18:42
@Nadrieril Nadrieril marked this pull request as ready for review November 24, 2024 20:21
@rustbot
Copy link
Collaborator

rustbot commented Nov 24, 2024

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

@Nadrieril
Copy link
Member Author

@rustbot ready

ytmimi
ytmimi reviewed Nov 24, 2024
View reviewed changes
fee1-dead
fee1-dead requested changes Nov 28, 2024
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2024
@Nadrieril
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 7, 2024
fee1-dead
fee1-dead requested changes Dec 8, 2024
View reviewed changes
Copy link
Member

@fee1-dead fee1-dead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 8, 2024
@Nadrieril
Copy link
Member Author

@bors r=@fee1-dead

@bors
Copy link
Collaborator

bors commented Dec 8, 2024

📌 Commit 2459dbb has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 8, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 8, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 8, 2024
@bors
Auto merge of rust-lang#134039 - matthiaskrgr:rollup-ix8kdg1, r=matth…
e888a15 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#133424 (Parse guard patterns)
 - rust-lang#133733 ( compiletest: show the difference between the normalized output and the actual output for lines which didn't match)
 - rust-lang#133993 (Fix: typo in E0751 error explanation)
 - rust-lang#134013 (Adds new intrinsic declaration)
 - rust-lang#134020 (Remove unnecessary `int_type_width_signed` function)
 - rust-lang#134024 (Advent of `tests/ui` (misc cleanups and improvements) [2/N])
 - rust-lang#134038 (deps: Update psm)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 8, 2024
@bors
Auto merge of rust-lang#134039 - matthiaskrgr:rollup-ix8kdg1, r=matth…
df5b8e3 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#133424 (Parse guard patterns)
 - rust-lang#133733 ( compiletest: show the difference between the normalized output and the actual output for lines which didn't match)
 - rust-lang#133993 (Fix: typo in E0751 error explanation)
 - rust-lang#134013 (Adds new intrinsic declaration)
 - rust-lang#134020 (Remove unnecessary `int_type_width_signed` function)
 - rust-lang#134024 (Advent of `tests/ui` (misc cleanups and improvements) [2/N])
 - rust-lang#134038 (deps: Update psm)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1868c8f into rust-lang:master Dec 9, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 9, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 9, 2024
@rust-timer
Unrolled build for rust-lang#133424
2bad485 
Rollup merge of rust-lang#133424 - Nadrieril:guard-patterns-parsing, r=fee1-dead

Parse guard patterns

This implements the parsing of [RFC3637 Guard Patterns](https://rust-lang.github.io/rfcs/3637-guard-patterns.html) (see also [tracking issue](rust-lang#129967)). This PR is extracted from rust-lang#129996 with minor modifications.

cc `@max-niederman`
@Nadrieril Nadrieril deleted the guard-patterns-parsing branch December 9, 2024 09:15
flip1995 pushed a commit to flip1995/rust that referenced this pull request Dec 15, 2024
@matthiaskrgr
Rollup merge of rust-lang#133424 - Nadrieril:guard-patterns-parsing, …
24ccb15 
…r=fee1-dead

Parse guard patterns

This implements the parsing of [RFC3637 Guard Patterns](https://rust-lang.github.io/rfcs/3637-guard-patterns.html) (see also [tracking issue](rust-lang#129967)). This PR is extracted from rust-lang#129996 with minor modifications.

cc `@max-niederman`
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ytmimi ytmimi ytmimi left review comments

@fee1-dead fee1-dead fee1-dead requested changes

+1 more reviewer

@max-niederman max-niederman max-niederman left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@fee1-dead fee1-dead

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Nadrieril @rustbot @rust-log-analyzer @bors @max-niederman @ytmimi @fee1-dead