Fix keyword_idents_2024 missing lifetimes in various positions #133989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intended to fix keyword_idents_2024 which was not checking for `'gen` in most positions.
rustbot
added
S-waiting-on-review
jieyouxu
reviewed
Dec 7, 2024
Comment on lines
+25
to
+31
| fn test<'gen>(_: &'gen i32) {} | ||
| //~^ ERROR `gen` is a keyword in the 2024 edition | ||
| //~| ERROR `gen` is a keyword in the 2024 edition | ||
| //[e2015]~| WARNING this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2024! | ||
| //[e2015]~| WARNING this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2024! | ||
| //[e2018]~| WARNING this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2024! | ||
| //[e2018]~| WARNING this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2024! |
There was a problem hiding this comment.
Remark: I know this gets eventually deduplicated, but the duplicate error messages are interesting
|
Hm, I don't believe this is the right solution. |
|
This is because the EarlyLint visitor is actually walking into lifetimes always, though it's a bit strange that it is for generic param declarations. |
|
Alternative: #133992 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
keyword_idents_2024lint which was missing'genin various positions (it was generally only catching macros and generic arguments). Lifetimes are only treated as an "ident" for the purpose ofvisit_identin generic arguments. In other positions, it needs to go throughvisit_lifetime.Fixes #133839