Skip to content

Disable backtrace-debuginfo.rs on windows-gnu #134842

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

jieyouxu
Copy link
Member

This test appears still flaky cf. #117097 on i686-mingw as observed in #131244 (comment).

r? compiler (or anyone, really)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 28, 2024
@jieyouxu
Copy link
Member Author

@bors p=5 (flaky test)
@bors rollup (feel free to rollup)

@jieyouxu jieyouxu added the A-testsuite Area: The testsuite used to check the correctness of rustc label Dec 28, 2024
@ibraheemdev
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 28, 2024

📌 Commit 378dc03 has been approved by ibraheemdev

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2024
@bors
Copy link
Collaborator

bors commented Dec 28, 2024

⌛ Testing commit 378dc03 with merge 7cb0849...

@bors
Copy link
Collaborator

bors commented Dec 28, 2024

☀️ Test successful - checks-actions
Approved by: ibraheemdev
Pushing 7cb0849 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 28, 2024
@bors bors merged commit 7cb0849 into rust-lang:master Dec 28, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 28, 2024
@jieyouxu jieyouxu deleted the disable-flaky-test branch December 28, 2024 09:30
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7cb0849): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.3% [2.3%, 2.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 762.197s -> 761.454s (-0.10%)
Artifact size: 325.56 MiB -> 325.55 MiB (-0.00%)

poliorcetics pushed a commit to poliorcetics/rust that referenced this pull request Dec 28, 2024
…eemdev

Disable `backtrace-debuginfo.rs` on windows-gnu

This test appears still flaky cf. rust-lang#117097 on `i686-mingw` as observed in rust-lang#131244 (comment).

r? compiler (or anyone, really)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants