-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Make it easier to run CI jobs locally #134898
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
a7b5acf
to
c2172a9
Compare
(if this lands, https://rustc-dev-guide.rust-lang.org/tests/docker.html#testing-with-docker will also need to be updated) |
c2172a9
to
bdbf783
Compare
This comment has been minimized.
This comment has been minimized.
bdbf783
to
0021c22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to work for me locally, nice 👍
The changes LGTM, but I'm not an infra reviewer, so r? infra |
This comment has been minimized.
This comment has been minimized.
c017f3f
to
28105d9
Compare
The `image` part didn't really make sense, especially since we started splitting CI jobs.
28105d9
to
9d015ed
Compare
The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. |
Rebased, applied review comments and also updated rustc-dev-guide. |
This comment has been minimized.
This comment has been minimized.
2f63bbe
to
65819b1
Compare
Sorry for the delay, I lost the GitHub notification somehow! @bors r+ |
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#134898 (Make it easier to run CI jobs locally) - rust-lang#135195 (Make `lit_to_mir_constant` and `lit_to_const` infallible) - rust-lang#135261 (Account for identity substituted items in symbol mangling) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#134898 (Make it easier to run CI jobs locally) - rust-lang#135195 (Make `lit_to_mir_constant` and `lit_to_const` infallible) - rust-lang#135261 (Account for identity substituted items in symbol mangling) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#134898 - Kobzol:ci-python-script, r=MarcoIeni Make it easier to run CI jobs locally This PR extends the Python CI script to perform a poor man's CI-like execution of a given CI job locally. It's not perfect, but it's better than nothing. r? `@jieyouxu`
Note to myself: next time we should mark CI affecting PRs with rollup=never :) |
CI: fix name of jobs There is a difference between the `image` (the Dockerfile), the `name` of the job (which determines also its properties) and the `full_name`, which includes the `auto/try/pr` prefix. Missed this in rust-lang#134898.
This PR extends the Python CI script to perform a poor man's CI-like execution of a given CI job locally. It's not perfect, but it's better than nothing.
r? @jieyouxu