Skip to content

Make it easier to run CI jobs locally #134898

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 7 commits into from
Jan 9, 2025
Merged

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Dec 29, 2024

This PR extends the Python CI script to perform a poor man's CI-like execution of a given CI job locally. It's not perfect, but it's better than nothing.

r? @jieyouxu

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 29, 2024
@lqd
Copy link
Member

lqd commented Dec 29, 2024

(if this lands, https://rustc-dev-guide.rust-lang.org/tests/docker.html#testing-with-docker will also need to be updated)

@rust-log-analyzer

This comment has been minimized.

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work for me locally, nice 👍

@jieyouxu
Copy link
Member

The changes LGTM, but I'm not an infra reviewer, so r? infra

@rustbot rustbot assigned marcoieni and unassigned jieyouxu Dec 31, 2024
@rust-log-analyzer

This comment has been minimized.

@rustbot rustbot added the A-rustc-dev-guide Area: rustc-dev-guide label Jan 7, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 7, 2025

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol

@Kobzol
Copy link
Contributor Author

Kobzol commented Jan 7, 2025

Rebased, applied review comments and also updated rustc-dev-guide.

@rust-log-analyzer

This comment has been minimized.

@marcoieni
Copy link
Member

Sorry for the delay, I lost the GitHub notification somehow!

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 9, 2025

📌 Commit 65819b1 has been approved by MarcoIeni

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2025
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#134898 (Make it easier to run CI jobs locally)
 - rust-lang#135195 (Make `lit_to_mir_constant` and `lit_to_const` infallible)
 - rust-lang#135261 (Account for identity substituted items in symbol mangling)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2025
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#134898 (Make it easier to run CI jobs locally)
 - rust-lang#135195 (Make `lit_to_mir_constant` and `lit_to_const` infallible)
 - rust-lang#135261 (Account for identity substituted items in symbol mangling)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d487294 into rust-lang:master Jan 9, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 9, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2025
Rollup merge of rust-lang#134898 - Kobzol:ci-python-script, r=MarcoIeni

Make it easier to run CI jobs locally

This PR extends the Python CI script to perform a poor man's CI-like execution of a given CI job locally. It's not perfect, but it's better than nothing.

r? `@jieyouxu`
@Kobzol Kobzol deleted the ci-python-script branch January 9, 2025 19:21
@Kobzol
Copy link
Contributor Author

Kobzol commented Jan 9, 2025

Note to myself: next time we should mark CI affecting PRs with rollup=never :)

@Kobzol Kobzol mentioned this pull request Jan 9, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 10, 2025
CI: fix name of jobs

There is a difference between the `image` (the Dockerfile), the `name` of the job (which determines also its properties) and the `full_name`, which includes the `auto/try/pr` prefix.

Missed this in rust-lang#134898.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants