Skip to content

bootstrap: support ./x check run-make-support #135066

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Jan 3, 2025

Mostly for working on src/tools/run-make-support locally.

@rustbot
Copy link
Collaborator

rustbot commented Jan 3, 2025

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 3, 2025
@clubby789
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 3, 2025

📌 Commit 6628c4b has been approved by clubby789

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 4, 2025
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#133964 (core: implement `bool::select_unpredictable`)
 - rust-lang#135001 (Allow using self-contained LLD in bootstrap)
 - rust-lang#135055 (Report impl method has stricter requirements even when RPITIT inference gets in the way)
 - rust-lang#135064 (const-in-pattern: test that the PartialEq impl does not need to be const)
 - rust-lang#135066 (bootstrap: support `./x check run-make-support`)
 - rust-lang#135069 (remove unused function params)
 - rust-lang#135084 (Update carrying_mul_add test to tolerate `nuw`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e4cc2db into rust-lang:master Jan 4, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 4, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 4, 2025
Rollup merge of rust-lang#135066 - jieyouxu:check-run-make-support, r=clubby789

bootstrap: support `./x check run-make-support`

Mostly for working on `src/tools/run-make-support` locally.
@jieyouxu jieyouxu deleted the check-run-make-support branch January 4, 2025 13:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants