Skip to content

bootstrap: If dir_is_empty fails, show the non-existent directory path #135094

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2025
Merged

bootstrap: If dir_is_empty fails, show the non-existent directory path #135094

merged 1 commit into from
Jan 4, 2025

Conversation

joshtriplett
Copy link
Member

This should help when trying to debug issues.

@joshtriplett
bootstrap: If dir_is_empty fails, show the non-existent directory path
2cefd30 
This should help when trying to debug issues.
@rustbot
Copy link
Collaborator

rustbot commented Jan 4, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 4, 2025
@joshtriplett joshtriplett mentioned this pull request Jan 4, 2025
Closed
jieyouxu
jieyouxu approved these changes Jan 4, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, thanks

@jieyouxu
Copy link
Member

jieyouxu commented Jan 4, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 4, 2025

📌 Commit 2cefd30 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2025
@jieyouxu jieyouxu assigned jieyouxu and unassigned Mark-Simulacrum Jan 4, 2025
@workingjubilee workingjubilee mentioned this pull request Jan 4, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 4, 2025
@bors
Auto merge of rust-lang#135101 - workingjubilee:rollup-owp3czl, r=wor…
1891c28 
…kingjubilee

Rollup of 6 pull requests

Successful merges:

 - rust-lang#135046 (turn rustc_box into an intrinsic)
 - rust-lang#135061 (crashes: add latest batch of tests)
 - rust-lang#135070 (std: sync to dep versions of backtrace)
 - rust-lang#135088 (Force code generation in assembly generation smoke-tests)
 - rust-lang#135091 (Bump backtrace to 0.3.75)
 - rust-lang#135094 (bootstrap: If dir_is_empty fails, show the non-existent directory path)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e2983d8 into rust-lang:master Jan 4, 2025
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 4, 2025
@rust-timer
Unrolled build for rust-lang#135094
0fe74c8 
Rollup merge of rust-lang#135094 - joshtriplett:bootstrap-show-nonexistent-dir, r=jieyouxu

bootstrap: If dir_is_empty fails, show the non-existent directory path

This should help when trying to debug issues.
@rustbot rustbot added this to the 1.86.0 milestone Jan 4, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
5 participants
@joshtriplett @rustbot @jieyouxu @bors @Mark-Simulacrum